This is an automated email from the ASF dual-hosted git repository. beto pushed a commit to branch file-handler2 in repository https://gitbox.apache.org/repos/asf/superset.git
commit ba8494360c13c856cebb1c98ed6d2f5ba315192f Author: Beto Dealmeida <[email protected]> AuthorDate: Tue Dec 16 10:44:38 2025 -0500 fix: use local types in service worker to avoid global pollution The webworker lib reference was adding ServiceWorker types globally, which conflicted with useBeforeUnload test. Use local type declarations instead. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]> --- superset-frontend/src/service-worker.ts | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/superset-frontend/src/service-worker.ts b/superset-frontend/src/service-worker.ts index 381a9ccc88..2791fd4c59 100644 --- a/superset-frontend/src/service-worker.ts +++ b/superset-frontend/src/service-worker.ts @@ -17,15 +17,21 @@ * under the License. */ -/// <reference lib="webworker" /> +// Service Worker types (declared locally to avoid polluting global scope) +declare const self: { + skipWaiting(): Promise<void>; + clients: { claim(): Promise<void> }; + addEventListener( + type: 'install' | 'activate', + listener: (event: { waitUntil(promise: Promise<unknown>): void }) => void, + ): void; +}; -declare const self: ServiceWorkerGlobalScope; - -self.addEventListener('install', (event: ExtendableEvent) => { +self.addEventListener('install', () => { self.skipWaiting(); }); -self.addEventListener('activate', (event: ExtendableEvent) => { +self.addEventListener('activate', event => { event.waitUntil(self.clients.claim()); });
