This is an automated email from the ASF dual-hosted git repository. kgabryje pushed a commit to branch what-if in repository https://gitbox.apache.org/repos/asf/superset.git
commit 8d40dbd422c9e92bd3ebd808aec589820e4aa582 Author: Kamil Gabryjelski <[email protected]> AuthorDate: Fri Dec 19 16:27:32 2025 +0100 better chart loading state --- superset-frontend/src/components/Chart/Chart.tsx | 5 ++--- .../src/pages/WhatIfSimulationList/index.tsx | 21 ++------------------- 2 files changed, 4 insertions(+), 22 deletions(-) diff --git a/superset-frontend/src/components/Chart/Chart.tsx b/superset-frontend/src/components/Chart/Chart.tsx index 0be79b6ef1..8043293776 100644 --- a/superset-frontend/src/components/Chart/Chart.tsx +++ b/superset-frontend/src/components/Chart/Chart.tsx @@ -167,7 +167,7 @@ const MessageSpan = styled.span` text-align: center; margin: ${({ theme }) => theme.sizeUnit * 4}px auto; width: fit-content; - color: ${({ theme }) => theme.colorText}; + color: ${({ theme }) => theme.colorPrimary}; `; const LoadingOverlay = styled.div` @@ -180,7 +180,7 @@ const LoadingOverlay = styled.div` flex-direction: column; align-items: center; justify-content: center; - background-color: ${({ theme }) => theme.colorBgMask}; + background-color: ${({ theme }) => theme.colorBgBase}cc; z-index: 10; `; @@ -338,7 +338,6 @@ class Chart extends PureComponent<ChartProps, {}> { <Loading position="inline-centered" size={this.props.dashboardId ? 's' : 'm'} - muted={!!this.props.dashboardId} /> <MessageSpan>{message}</MessageSpan> </LoadingOverlay> diff --git a/superset-frontend/src/pages/WhatIfSimulationList/index.tsx b/superset-frontend/src/pages/WhatIfSimulationList/index.tsx index 7b8a89d9d3..ed815069b7 100644 --- a/superset-frontend/src/pages/WhatIfSimulationList/index.tsx +++ b/superset-frontend/src/pages/WhatIfSimulationList/index.tsx @@ -18,7 +18,7 @@ */ import { useMemo, useState, useEffect, useCallback } from 'react'; -import { Link, useHistory } from 'react-router-dom'; +import { Link } from 'react-router-dom'; import { t, SupersetClient } from '@superset-ui/core'; import { css, styled, useTheme } from '@apache-superset/core/ui'; import { extendedDayjs as dayjs } from '@superset-ui/core/utils/dates'; @@ -174,7 +174,6 @@ function WhatIfSimulationList({ addDangerToast, addSuccessToast, }: WhatIfSimulationListProps) { - const history = useHistory(); const [simulations, setSimulations] = useState<WhatIfSimulation[]>([]); const [dashboards, setDashboards] = useState<Record<number, DashboardInfo>>( {}, @@ -396,26 +395,10 @@ function WhatIfSimulationList({ }: { row: { original: WhatIfSimulation }; }) => { - const dashboard = dashboards[original.dashboardId]; - const dashboardUrl = dashboard?.slug - ? `/superset/dashboard/${dashboard.slug}/` - : `/superset/dashboard/${original.dashboardId}/`; - const simulationUrl = `${dashboardUrl}?simulation=${original.id}`; - - const handleOpen = () => { - history.push(simulationUrl); - }; const handleEdit = () => setSimulationCurrentlyEditing(original); const handleDelete = () => setSimulationCurrentlyDeleting(original); const actions = [ - { - label: 'open-action', - tooltip: t('Open in Dashboard'), - placement: 'bottom', - icon: 'ExportOutlined', - onClick: handleOpen, - }, { label: 'edit-action', tooltip: t('Edit modifications'), @@ -442,7 +425,7 @@ function WhatIfSimulationList({ disableSortBy: true, }, ], - [dashboards, history, columnVerboseNames], + [dashboards, columnVerboseNames], ); const emptyState = {
