This is an automated email from the ASF dual-hosted git repository. rusackas pushed a commit to branch fix-timezone-mock in repository https://gitbox.apache.org/repos/asf/superset.git
commit c0763fe58f9c1d598b2592af759713331c3eafed Author: Evan Rusackas <[email protected]> AuthorDate: Mon Jan 26 09:26:24 2026 -0800 fix(tests): update timezone-mock usage for v1.4.0 compatibility In timezone-mock 1.4.0, the timezone must be registered BEFORE setting the system time via jest.setSystemTime(). The previous order (setting time first, then registering timezone) caused date calculations to be off by 1 day. This fixes test failures in: - packages/superset-ui-core/test/time-comparison/getTimeOffset.test.ts - packages/superset-ui-core/test/time-comparison/parseDttmToDate.test.ts Co-Authored-By: Claude Opus 4.5 <[email protected]> --- .../superset-ui-core/test/time-comparison/getTimeOffset.test.ts | 4 ++-- .../superset-ui-core/test/time-comparison/parseDttmToDate.test.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/superset-frontend/packages/superset-ui-core/test/time-comparison/getTimeOffset.test.ts b/superset-frontend/packages/superset-ui-core/test/time-comparison/getTimeOffset.test.ts index 877fd9981e5..87ce93280a4 100644 --- a/superset-frontend/packages/superset-ui-core/test/time-comparison/getTimeOffset.test.ts +++ b/superset-frontend/packages/superset-ui-core/test/time-comparison/getTimeOffset.test.ts @@ -39,8 +39,8 @@ const runTimezoneTest = ( expected_result: string[], includeFutureOffsets = true, ) => { - jest.setSystemTime(new Date(now_time)); timezoneMock.register(timezone); + jest.setSystemTime(new Date(now_time)); const result = getTimeOffset({ timeRangeFilter, shifts, @@ -53,8 +53,8 @@ const runTimezoneTest = ( test('should handle includeFutureOffsets is null', () => { jest.useFakeTimers(); - jest.setSystemTime(new Date(NOW_UTC_IN_EUROPE)); timezoneMock.register('Etc/GMT-2'); + jest.setSystemTime(new Date(NOW_UTC_IN_EUROPE)); const result = getTimeOffset({ timeRangeFilter: { comparator: '2024-06-03 : 2024-06-10', diff --git a/superset-frontend/packages/superset-ui-core/test/time-comparison/parseDttmToDate.test.ts b/superset-frontend/packages/superset-ui-core/test/time-comparison/parseDttmToDate.test.ts index 496213dea71..10226a38fcf 100644 --- a/superset-frontend/packages/superset-ui-core/test/time-comparison/parseDttmToDate.test.ts +++ b/superset-frontend/packages/superset-ui-core/test/time-comparison/parseDttmToDate.test.ts @@ -38,8 +38,8 @@ const runTimezoneTest = ( endDate = false, computingShift = false, ) => { - jest.setSystemTime(new Date(now_time)); timezoneMock.register(timezone); + jest.setSystemTime(new Date(now_time)); expect(parseDttmToDate(eval_time, endDate, computingShift)).toEqual( expected_result, );
