This is an automated email from the ASF dual-hosted git repository.

rusackas pushed a commit to branch fix/console-noise-cleanup
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/fix/console-noise-cleanup by 
this push:
     new ab47683b647 fix(frontend): fix roles page console warnings
ab47683b647 is described below

commit ab47683b647af62e5fd1658e76bdb399a00170e2
Author: Evan Rusackas <[email protected]>
AuthorDate: Tue Feb 10 23:09:03 2026 -0800

    fix(frontend): fix roles page console warnings
    
    - Fix missing key prop in ActionsBar list rendering
    - Convert deprecated Modal bodyStyle to styles.body API
    
    Co-Authored-By: Claude Opus 4.5 <[email protected]>
---
 .../packages/superset-ui-core/src/components/Modal/Modal.tsx      | 8 ++++++++
 .../packages/superset-ui-core/src/components/Modal/types.ts       | 2 ++
 superset-frontend/src/components/ListView/ActionsBar.tsx          | 2 +-
 3 files changed, 11 insertions(+), 1 deletion(-)

diff --git 
a/superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.tsx 
b/superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.tsx
index 021341808e0..d5b867626ee 100644
--- a/superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.tsx
@@ -227,8 +227,15 @@ const CustomModal = ({
   draggableConfig,
   destroyOnHidden,
   openerRef,
+  bodyStyle,
+  styles: stylesProp,
   ...rest
 }: ModalProps) => {
+  // Convert deprecated bodyStyle to styles.body
+  const styles = useMemo(
+    () => (bodyStyle ? { ...stylesProp, body: bodyStyle } : stylesProp),
+    [bodyStyle, stylesProp],
+  );
   const draggableRef = useRef<HTMLDivElement>(null);
   const [bounds, setBounds] = useState<DraggableBounds>();
   const [dragDisabled, setDragDisabled] = useState<boolean>(true);
@@ -361,6 +368,7 @@ const CustomModal = ({
       draggable={draggable}
       resizable={resizable}
       destroyOnHidden={destroyOnHidden}
+      styles={styles}
       {...rest}
     >
       {children}
diff --git 
a/superset-frontend/packages/superset-ui-core/src/components/Modal/types.ts 
b/superset-frontend/packages/superset-ui-core/src/components/Modal/types.ts
index 7876a1bc46c..4966bc7ac1e 100644
--- a/superset-frontend/packages/superset-ui-core/src/components/Modal/types.ts
+++ b/superset-frontend/packages/superset-ui-core/src/components/Modal/types.ts
@@ -51,7 +51,9 @@ export interface ModalProps {
   destroyOnHidden?: boolean;
   maskClosable?: boolean;
   zIndex?: number;
+  /** @deprecated Use styles.body instead */
   bodyStyle?: CSSProperties;
+  styles?: { body?: CSSProperties; [key: string]: CSSProperties | undefined };
   openerRef?: React.RefObject<HTMLElement>;
 }
 
diff --git a/superset-frontend/src/components/ListView/ActionsBar.tsx 
b/superset-frontend/src/components/ListView/ActionsBar.tsx
index 503b3bbee91..38dff4639c7 100644
--- a/superset-frontend/src/components/ListView/ActionsBar.tsx
+++ b/superset-frontend/src/components/ListView/ActionsBar.tsx
@@ -68,7 +68,7 @@ export function ActionsBar({ actions }: ActionsBarProps) {
         const IconComponent = Icons[icon as IconNameType];
         return (
           <ActionButton
-            key={tooltip ? undefined : index}
+            key={rest.label ?? index}
             icon={<IconComponent iconSize="l" />}
             tooltip={tooltip}
             {...rest}

Reply via email to