This is an automated email from the ASF dual-hosted git repository. enzomartellucci pushed a commit to branch enxdev/fix/chart-error-alerts in repository https://gitbox.apache.org/repos/asf/superset.git
commit e2f367f27b6f7bd7ff7c231b7a3c682fc03780e6 Author: Enzo Martellucci <[email protected]> AuthorDate: Mon Feb 16 15:40:33 2026 +0100 test(chart): closable behavior tests --- .../src/components/Chart/ChartErrorMessage.test.tsx | 2 +- .../ErrorMessage/ErrorMessageWithStackTrace.test.tsx | 12 ++++++++++++ .../dashboard/components/gridComponents/Chart/Chart.test.tsx | 2 +- 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/superset-frontend/src/components/Chart/ChartErrorMessage.test.tsx b/superset-frontend/src/components/Chart/ChartErrorMessage.test.tsx index 48c19c80616..5a96d6c108c 100644 --- a/superset-frontend/src/components/Chart/ChartErrorMessage.test.tsx +++ b/superset-frontend/src/components/Chart/ChartErrorMessage.test.tsx @@ -92,7 +92,7 @@ describe('ChartErrorMessage', () => { render(<ChartErrorMessage {...defaultProps} />); expect( - screen.queryByRole('button', { name: 'Close' }), + screen.queryByRole('button', { name: /close/i }), ).not.toBeInTheDocument(); }); }); diff --git a/superset-frontend/src/components/ErrorMessage/ErrorMessageWithStackTrace.test.tsx b/superset-frontend/src/components/ErrorMessage/ErrorMessageWithStackTrace.test.tsx index b27ff32d00a..4b9c5946e76 100644 --- a/superset-frontend/src/components/ErrorMessage/ErrorMessageWithStackTrace.test.tsx +++ b/superset-frontend/src/components/ErrorMessage/ErrorMessageWithStackTrace.test.tsx @@ -58,6 +58,18 @@ test('should render the link', () => { expect(link).toHaveAttribute('href', mockedProps.link); }); +test('should render a close button by default', () => { + render(<ErrorMessageWithStackTrace {...mockedProps} />); + expect(screen.getByRole('button', { name: /close/i })).toBeInTheDocument(); +}); + +test('should not render a close button when closable is false', () => { + render(<ErrorMessageWithStackTrace {...mockedProps} closable={false} />); + expect( + screen.queryByRole('button', { name: /close/i }), + ).not.toBeInTheDocument(); +}); + test('should render the fallback', () => { const body = 'Blahblah'; render( diff --git a/superset-frontend/src/dashboard/components/gridComponents/Chart/Chart.test.tsx b/superset-frontend/src/dashboard/components/gridComponents/Chart/Chart.test.tsx index 822fdf754c9..7ef19dce5fb 100644 --- a/superset-frontend/src/dashboard/components/gridComponents/Chart/Chart.test.tsx +++ b/superset-frontend/src/dashboard/components/gridComponents/Chart/Chart.test.tsx @@ -392,7 +392,7 @@ test('should not show a close button on chart error banners', () => { }, ); - expect(queryByRole('button', { name: 'Close' })).not.toBeInTheDocument(); + expect(queryByRole('button', { name: /close/i })).not.toBeInTheDocument(); }); test('should handle chart state when no converter exists', () => {
