This is an automated email from the ASF dual-hosted git repository. hainenber pushed a commit to branch dependabot/npm_and_yarn/superset-frontend/storybook-708d5b7d52 in repository https://gitbox.apache.org/repos/asf/superset.git
commit e486fc406edccb20252ce56707dd5eb021b3b935 Author: hainenber <[email protected]> AuthorDate: Wed Feb 18 20:49:21 2026 +0700 build: allow building Storybook components without React16 shim Signed-off-by: hainenber <[email protected]> --- superset-frontend/.storybook/main.js | 2 +- superset-frontend/webpack.config.js | 9 --------- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/superset-frontend/.storybook/main.js b/superset-frontend/.storybook/main.js index 19bef4da68d..53799f3100b 100644 --- a/superset-frontend/.storybook/main.js +++ b/superset-frontend/.storybook/main.js @@ -115,7 +115,7 @@ module.exports = { }), typescript: { - reactDocgen: 'react-docgen-typescript', + reactDocgen: getAbsolutePath('react-docgen-typescript'), }, framework: { diff --git a/superset-frontend/webpack.config.js b/superset-frontend/webpack.config.js index 604fcecae4f..da8c3689b41 100644 --- a/superset-frontend/webpack.config.js +++ b/superset-frontend/webpack.config.js @@ -455,15 +455,6 @@ const config = { This prevents "Module not found" errors for moment locale files. */ 'moment/min/moment-with-locales': false, - // Storybook 8 expects React 18's createRoot API. Since this project uses React 17, - // we alias to the react-16 shim which provides the legacy ReactDOM.render API. - // Remove this alias when React is upgraded to v18+. - '@storybook/react-dom-shim': path.resolve( - path.join( - APP_DIR, - './node_modules/@storybook/react-dom-shim/dist/react-16', - ), - ), }, extensions: ['.ts', '.tsx', '.js', '.jsx', '.yml'], fallback: {
