(superset) branch master updated: fix(dataset-modal): fix folders tab scrollbar by establishing proper flex chain (#38123)

[kgabryje]

This is an automated email from the ASF dual-hosted git repository.

kgabryje pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new e30a9caba51 fix(dataset-modal): fix folders tab scrollbar by 
establishing proper flex chain (#38123)
e30a9caba51 is described below

commit e30a9caba51c79e5dc52fa4b7d1be16c530d4a9e
Author: Kamil Gabryjelski <kamil.gabryjel...@gmail.com>
AuthorDate: Fri Feb 20 16:54:23 2026 +0100

    fix(dataset-modal): fix folders tab scrollbar by establishing proper flex 
chain (#38123)
    
    Co-authored-by: Claude Opus 4.6 <nore...@anthropic.com>
---
 .../Datasource/DatasourceModal/index.tsx           | 17 ++++------------
 .../components/Datasource/FoldersEditor/styles.tsx |  2 +-
 .../DatasourceEditor/DatasourceEditor.tsx          | 23 ++++++++++++++++++++--
 3 files changed, 26 insertions(+), 16 deletions(-)

diff --git 
a/superset-frontend/src/components/Datasource/DatasourceModal/index.tsx 
b/superset-frontend/src/components/Datasource/DatasourceModal/index.tsx
index 7b2dd6a6503..a6e3e84f949 100644
--- a/superset-frontend/src/components/Datasource/DatasourceModal/index.tsx
+++ b/superset-frontend/src/components/Datasource/DatasourceModal/index.tsx
@@ -45,23 +45,14 @@ const DatasourceEditor = AsyncEsmComponent(
 );
 
 const StyledDatasourceModal = styled(Modal)`
-  .modal-content {
+  && .ant-modal-content {
     height: 900px;
-    display: flex;
-    flex-direction: column;
-    align-items: stretch;
   }
 
-  .modal-header {
-    flex: 0 1 auto;
-  }
-  .modal-body {
+  && .ant-modal-body {
     flex: 1 1 auto;
-    overflow: auto;
-  }
-
-  .modal-footer {
-    flex: 0 1 auto;
+    display: flex;
+    flex-direction: column;
   }
 
   .ant-tabs-top {
diff --git 
a/superset-frontend/src/components/Datasource/FoldersEditor/styles.tsx 
b/superset-frontend/src/components/Datasource/FoldersEditor/styles.tsx
index b24fc658d2c..1c62cfa2802 100644
--- a/superset-frontend/src/components/Datasource/FoldersEditor/styles.tsx
+++ b/superset-frontend/src/components/Datasource/FoldersEditor/styles.tsx
@@ -22,7 +22,7 @@ export const FoldersContainer = styled.div`
   display: flex;
   flex-direction: column;
   position: relative;
-  height: 70vh;
+  height: 100%;
   gap: ${({ theme }) => theme.paddingMD}px;
 `;
 
diff --git 
a/superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.tsx
 
b/superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.tsx
index fae377266a6..58c15ddcb28 100644
--- 
a/superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.tsx
+++ 
b/superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.tsx
@@ -319,6 +319,11 @@ interface OwnersSelectorProps {
 }
 
 const DatasourceContainer = styled.div`
+  flex: 1;
+  min-height: 0;
+  display: flex;
+  flex-direction: column;
+
   .change-warning {
     margin: 16px 10px 0;
     color: ${({ theme }) => theme.colorWarning};
@@ -347,9 +352,23 @@ const FlexRowContainer = styled.div`
 `;
 
 const StyledTableTabs = styled(Tabs)`
-  overflow: visible;
+  flex: 1;
+  min-height: 0;
+  display: flex;
+  flex-direction: column;
+
   .ant-tabs-content-holder {
-    overflow: visible;
+    flex: 1;
+    min-height: 0;
+    overflow: auto;
+  }
+
+  .ant-tabs-content {
+    height: 100%;
+  }
+
+  .ant-tabs-tabpane-active {
+    height: 100%;
   }
 `;