This is an automated email from the ASF dual-hosted git repository.
enzomartellucci pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new 26053a8b5d3 fix(alert-modal): show the add filter button on firefox
(#38093)
26053a8b5d3 is described below
commit 26053a8b5d3808c91b2d43297cf8d22e7b2d87d8
Author: Enzo Martellucci <[email protected]>
AuthorDate: Wed Feb 25 23:42:05 2026 +0100
fix(alert-modal): show the add filter button on firefox (#38093)
---
.../src/features/alerts/AlertReportModal.tsx | 43 ++++++----------------
1 file changed, 12 insertions(+), 31 deletions(-)
diff --git a/superset-frontend/src/features/alerts/AlertReportModal.tsx
b/superset-frontend/src/features/alerts/AlertReportModal.tsx
index 39c15b18aed..87ffbf0f402 100644
--- a/superset-frontend/src/features/alerts/AlertReportModal.tsx
+++ b/superset-frontend/src/features/alerts/AlertReportModal.tsx
@@ -60,6 +60,7 @@ import {
Select,
Switch,
TreeSelect,
+ Button,
type CheckboxChangeEvent,
} from '@superset-ui/core/components';
@@ -377,15 +378,6 @@ export const StyledInputContainer = styled.div`
display: 'flex';
color: ${theme.colorIcon};
}
- .filters-add-container {
- flex: '.25';
- padding: '${theme.sizeUnit * 3} 0';
-
- .filters-add-btn {
- padding: ${theme.sizeUnit * 2}px;
- color: ${theme.colorWhite};
- }
- }
}
`}
`;
@@ -2509,28 +2501,17 @@ const AlertReportModal:
FunctionComponent<AlertReportModalProps> = ({
)}
</div>
))}
- <div className="filters-add-container">
- {filterNativeFilterOptions().length > 0 && (
- // eslint-disable-next-line
jsx-a11y/anchor-is-valid
- <a
- className="filters-add-btn"
- role="button"
- tabIndex={0}
- onClick={() => {
- handleAddFilterField();
- add();
- }}
- onKeyDown={e => {
- if (e.key === 'Enter' || e.key === ' ') {
- handleAddFilterField();
- add();
- }
- }}
- >
- + {t('Apply another dashboard filter')}
- </a>
- )}
- </div>
+ {filterNativeFilterOptions().length > 0 && (
+ <Button
+ buttonStyle="link"
+ onClick={() => {
+ handleAddFilterField();
+ add();
+ }}
+ >
+ + {t('Apply another dashboard filter')}
+ </Button>
+ )}
</div>
)}
</AntdForm.List>
