This is an automated email from the ASF dual-hosted git repository. maximebeauchemin pushed a commit to branch investigate-ace-cursor-bug in repository https://gitbox.apache.org/repos/asf/superset.git
commit f6879240b3c7b09cecc72b77449fe28c11fbca88 Author: Kamil Gabryjelski <[email protected]> AuthorDate: Fri Mar 6 00:31:44 2026 +0000 fix(dev): allow external access to webpack dev server via env var Add WEBPACK_ALLOW_ALL_HOSTS env var to opt into webpack-dev-server allowedHosts: 'all', enabling access from external IPs (e.g. remote dev environments). Default behavior is unchanged for local development. Also adds .agor.yml environment template for docker-compose-light.yml and passes the new env var in the light compose config. Co-Authored-By: Claude Opus 4.6 <[email protected]> --- .agor.yml | 12 ++++++++++++ docker-compose-light.yml | 1 + superset-frontend/webpack.config.js | 22 ++++++++++++---------- 3 files changed, 25 insertions(+), 10 deletions(-) diff --git a/.agor.yml b/.agor.yml new file mode 100644 index 00000000000..b0cc0d97e97 --- /dev/null +++ b/.agor.yml @@ -0,0 +1,12 @@ +environment: + up_command: >- + NODE_PORT={{add 9100 worktree.unique_id}} + docker compose -p {{worktree.name}} -f docker-compose-light.yml up -d + down_command: >- + docker compose -p {{worktree.name}} -f docker-compose-light.yml down + nuke_command: >- + docker compose -p {{worktree.name}} -f docker-compose-light.yml down -v + health_check_url: 'http://localhost:{{add 9100 worktree.unique_id}}/health' + app_url: 'http://10.33.93.131:{{add 9100 worktree.unique_id}}' + logs_command: >- + docker compose -p {{worktree.name}} -f docker-compose-light.yml logs --tail=100 superset-node-light diff --git a/docker-compose-light.yml b/docker-compose-light.yml index 1d0a4a90be7..bfabb873b91 100644 --- a/docker-compose-light.yml +++ b/docker-compose-light.yml @@ -162,6 +162,7 @@ services: # Webpack dev server must bind to 0.0.0.0 to be accessible from outside the container WEBPACK_DEVSERVER_HOST: "${WEBPACK_DEVSERVER_HOST:-0.0.0.0}" WEBPACK_DEVSERVER_PORT: "${WEBPACK_DEVSERVER_PORT:-9000}" + WEBPACK_ALLOW_ALL_HOSTS: "${WEBPACK_ALLOW_ALL_HOSTS:-true}" ports: - "${NODE_PORT:-9001}:9000" # Parameterized port, accessible on all interfaces command: ["/app/docker/docker-frontend.sh"] diff --git a/superset-frontend/webpack.config.js b/superset-frontend/webpack.config.js index 7dffa33dd1c..e1a7b30e910 100644 --- a/superset-frontend/webpack.config.js +++ b/superset-frontend/webpack.config.js @@ -666,16 +666,18 @@ if (isDevMode) { liveReload: false, host: devserverHost, port: devserverPort, - allowedHosts: [ - ...new Set([ - devserverHost, - 'localhost', - '.localhost', - '127.0.0.1', - '::1', - '.local', - ]), - ], + allowedHosts: process.env.WEBPACK_ALLOW_ALL_HOSTS + ? 'all' + : [ + ...new Set([ + devserverHost, + 'localhost', + '.localhost', + '127.0.0.1', + '::1', + '.local', + ]), + ], proxy: [() => proxyConfig], client: { overlay: {
