This is an automated email from the ASF dual-hosted git repository. rusackas pushed a commit to branch pr-38174 in repository https://gitbox.apache.org/repos/asf/superset.git
commit 9dd93d38b6245541977852a441097654a7285ac8 Author: Evan Rusackas <[email protected]> AuthorDate: Sun Feb 22 21:40:15 2026 -0800 test(sql): add tests for Partition class Add unit tests for the Partition class to cover __str__ and __eq__ methods and achieve 100% code coverage. Co-Authored-By: Claude Opus 4.5 <[email protected]> --- tests/unit_tests/sql/parse_tests.py | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/tests/unit_tests/sql/parse_tests.py b/tests/unit_tests/sql/parse_tests.py index 57bab2b9589..277180c73a1 100644 --- a/tests/unit_tests/sql/parse_tests.py +++ b/tests/unit_tests/sql/parse_tests.py @@ -30,6 +30,7 @@ from superset.sql.parse import ( KQLTokenType, KustoKQLStatement, LimitMethod, + Partition, process_jinja_sql, remove_quotes, RLSMethod, @@ -137,6 +138,36 @@ def test_table_qualify() -> None: assert qualified.catalog == table.catalog +def test_partition() -> None: + """ + Test the `Partition` class and its string conversion. + """ + # Test partitioned table with partition columns + partition = Partition(is_partitioned_table=True, partition_column=["col1", "col2"]) + assert partition.is_partitioned_table is True + assert partition.partition_column == ["col1", "col2"] + assert ( + str(partition) + == "Partition(is_partitioned_table=True, partition_column=[col1, col2])" + ) + + # Test non-partitioned table + partition_none = Partition(is_partitioned_table=False, partition_column=None) + assert partition_none.is_partitioned_table is False + assert partition_none.partition_column is None + assert ( + str(partition_none) + == "Partition(is_partitioned_table=False, partition_column=[None])" + ) + + # Test equality + partition1 = Partition(is_partitioned_table=True, partition_column=["col1"]) + partition2 = Partition(is_partitioned_table=True, partition_column=["col1"]) + partition3 = Partition(is_partitioned_table=True, partition_column=["col2"]) + assert partition1 == partition2 + assert partition1 != partition3 + + def extract_tables_from_sql(sql: str, engine: str = "postgresql") -> set[Table]: """ Helper function to extract tables from SQL.
