This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new fed29b3017d fix(deploy): prevent double-prefix of logo URL in
subdirectory deployments (#39472)
fed29b3017d is described below
commit fed29b3017d5eb9f744a4afe3ace12926b75cf48
Author: Abdul Rehman <[email protected]>
AuthorDate: Tue May 12 09:13:26 2026 +0500
fix(deploy): prevent double-prefix of logo URL in subdirectory deployments
(#39472)
Co-authored-by: Claude Opus 4.6 (1M context) <[email protected]>
---
superset/app.py | 16 ----------------
1 file changed, 16 deletions(-)
diff --git a/superset/app.py b/superset/app.py
index 3edf16eb41c..aeaee5e35a0 100644
--- a/superset/app.py
+++ b/superset/app.py
@@ -71,22 +71,6 @@ def create_app(
# value of app_root so things work out of the box
if not app.config["STATIC_ASSETS_PREFIX"]:
app.config["STATIC_ASSETS_PREFIX"] = app_root
- # Prefix APP_ICON path with subdirectory root for subdirectory
deployments
- if (
- app.config.get("APP_ICON", "").startswith("/static/")
- and app_root != "/"
- ):
- app.config["APP_ICON"] = f"{app_root}{app.config['APP_ICON']}"
- # Also update theme tokens for subdirectory deployments
- for theme_key in ("THEME_DEFAULT", "THEME_DARK"):
- theme = app.config[theme_key]
- token = theme.get("token", {})
- # Update brandLogoUrl if it points to /static/
- if token.get("brandLogoUrl", "").startswith("/static/"):
- token["brandLogoUrl"] =
f"{app_root}{token['brandLogoUrl']}"
- # Update brandLogoHref if it's the default "/"
- if token.get("brandLogoHref") == "/":
- token["brandLogoHref"] = app_root
if app.config["APPLICATION_ROOT"] == "/":
app.config["APPLICATION_ROOT"] = app_root
