This is an automated email from the ASF dual-hosted git repository. kasiazjc pushed a commit to branch fix/column-select-saved-tab-label in repository https://gitbox.apache.org/repos/asf/superset.git
commit f1d13e11dd425fdc213023506cb65b52b64f03b8 Author: kasiazjc <[email protected]> AuthorDate: Mon May 25 16:30:16 2026 +0000 fix(explore): rename 'Saved' column tab to 'Calculated' for consistency The column select popover in Explore labeled this tab "Saved", while the Dataset Editor calls the same concept "Calculated columns". Aligns the Explore tab label with the Dataset terminology to reduce user confusion. Fixes #sc-46962 --- .../DndColumnSelectControl/ColumnSelectPopover.test.tsx | 10 +++++----- .../controls/DndColumnSelectControl/ColumnSelectPopover.tsx | 8 ++++---- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.test.tsx b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.test.tsx index 4c3d0fa13aa..d51516a1224 100644 --- a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.test.tsx +++ b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.test.tsx @@ -111,19 +111,19 @@ test('open with Simple tab selected when there is no column selected', () => { getCurrentTab: jest.fn(), onChange: jest.fn(), }); - expect(getByText('Saved')).toHaveAttribute('aria-selected', 'false'); + expect(getByText('Calculated')).toHaveAttribute('aria-selected', 'false'); expect(getByText('Simple')).toHaveAttribute('aria-selected', 'true'); expect(getByText('Custom SQL')).toHaveAttribute('aria-selected', 'false'); }); -test('open with Saved tab selected when there is a saved column selected', () => { +test('open with Calculated tab selected when there is a saved column selected', () => { const { getByText } = renderPopover({ columns: [{ column_name: 'year' }], editedColumn: { column_name: 'year', expression: 'year - 1' }, getCurrentTab: jest.fn(), onChange: jest.fn(), }); - expect(getByText('Saved')).toHaveAttribute('aria-selected', 'true'); + expect(getByText('Calculated')).toHaveAttribute('aria-selected', 'true'); expect(getByText('Simple')).toHaveAttribute('aria-selected', 'false'); expect(getByText('Custom SQL')).toHaveAttribute('aria-selected', 'false'); }); @@ -139,7 +139,7 @@ test('open with Custom SQL tab selected when there is a custom SQL selected', () getCurrentTab: jest.fn(), onChange: jest.fn(), }); - expect(getByText('Saved')).toHaveAttribute('aria-selected', 'false'); + expect(getByText('Calculated')).toHaveAttribute('aria-selected', 'false'); expect(getByText('Simple')).toHaveAttribute('aria-selected', 'false'); expect(getByText('Custom SQL')).toHaveAttribute('aria-selected', 'true'); }); @@ -283,7 +283,7 @@ test('Should filter saved expressions by column_name and verbose_name', async () fireEvent.click(savedTab!); const combobox = screen.getByRole('combobox', { - name: 'Saved expressions', + name: 'Calculated columns', }); await userEvent.type(combobox, 'revenue'); diff --git a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.tsx b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.tsx index 1e69be2c45e..2f7b303fefb 100644 --- a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.tsx +++ b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.tsx @@ -382,7 +382,7 @@ const ColumnSelectPopover = ({ selectedMetric?.metric_name !== undefined || adhocColumn?.sqlExpression !== initialAdhocColumn?.sqlExpression; - const savedExpressionsLabel = t('Saved expressions'); + const savedExpressionsLabel = t('Calculated columns'); const simpleColumnsLabel = t('Columns and metrics'); const keywords = useMemo( () => sqlKeywords.concat(getColumnKeywords(columns)), @@ -408,7 +408,7 @@ const ColumnSelectPopover = ({ : [ { key: TABS_KEYS.SAVED, - label: t('Saved'), + label: t('Calculated'), children: ( <> {calculatedColumns.length > 0 ? ( @@ -448,7 +448,7 @@ const ColumnSelectPopover = ({ title={ isTemporal ? t('No temporal columns found') - : t('No saved expressions found') + : t('No calculated columns found') } description={ isTemporal @@ -467,7 +467,7 @@ const ColumnSelectPopover = ({ title={ isTemporal ? t('No temporal columns found') - : t('No saved expressions found') + : t('No calculated columns found') } description={ isTemporal ? (
