This is an automated email from the ASF dual-hosted git repository. rusackas pushed a commit to branch feat/glyph-single-file in repository https://gitbox.apache.org/repos/asf/superset.git
commit c72e40496a1d6adc57dca86308b2aa4b993a04c8 Author: Evan Rusackas <[email protected]> AuthorDate: Mon May 25 19:37:56 2026 -0700 fix(glyph): pass merged props directly in table/pivot/word-cloud renders Same bug as in the deckgl fix: `({ transformedProps })` destructures undefined when the transform returns a flat object instead of wrapping in `{ transformedProps: { ... } }`. The ECharts charts wrap (so they work); table, pivot-table, and word-cloud don't, so they were rendering their inner component with no props. 45 tests across the three plugins still pass. Co-Authored-By: Claude Sonnet 4.6 <[email protected]> --- superset-frontend/plugins/plugin-chart-pivot-table/src/index.tsx | 2 +- superset-frontend/plugins/plugin-chart-table/src/index.tsx | 4 ++-- superset-frontend/plugins/plugin-chart-word-cloud/src/index.tsx | 4 +--- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/superset-frontend/plugins/plugin-chart-pivot-table/src/index.tsx b/superset-frontend/plugins/plugin-chart-pivot-table/src/index.tsx index 2539e506ebb..41525dfbedf 100644 --- a/superset-frontend/plugins/plugin-chart-pivot-table/src/index.tsx +++ b/superset-frontend/plugins/plugin-chart-pivot-table/src/index.tsx @@ -67,7 +67,7 @@ const PivotTableChartPlugin = defineChart< transform: chartProps => transformProps(chartProps as ChartProps<QueryFormData>), // eslint-disable-next-line @typescript-eslint/no-explicit-any - render: ({ transformedProps }) => <PivotTableChart {...(transformedProps as any)} />, + render: props => <PivotTableChart {...(props as any)} />, }); export { PivotTableChartPlugin }; diff --git a/superset-frontend/plugins/plugin-chart-table/src/index.tsx b/superset-frontend/plugins/plugin-chart-table/src/index.tsx index 280b6bd723c..110ea71416b 100644 --- a/superset-frontend/plugins/plugin-chart-table/src/index.tsx +++ b/superset-frontend/plugins/plugin-chart-table/src/index.tsx @@ -84,9 +84,9 @@ const TableChartPlugin = defineChart<Record<string, never>, TableChartProps>({ buildQuery: (formData: any) => buildQuery(formData), // eslint-disable-next-line @typescript-eslint/no-explicit-any transform: chartProps => transformProps(chartProps as any) as any, - render: ({ transformedProps }) => ( + render: props => ( // eslint-disable-next-line @typescript-eslint/no-explicit-any - <TableChart {...(transformedProps as any)} /> + <TableChart {...(props as any)} /> ), }); diff --git a/superset-frontend/plugins/plugin-chart-word-cloud/src/index.tsx b/superset-frontend/plugins/plugin-chart-word-cloud/src/index.tsx index 7bdebafa70c..76236d0fe31 100644 --- a/superset-frontend/plugins/plugin-chart-word-cloud/src/index.tsx +++ b/superset-frontend/plugins/plugin-chart-word-cloud/src/index.tsx @@ -231,9 +231,7 @@ const WordCloudChartPlugin = defineChart<Record<string, never>, WordCloudProps>( }), transform: chartProps => transformProps(chartProps as ChartProps), buildQuery: (formData: WordCloudFormData) => buildQuery(formData), - render: ({ transformedProps }) => ( - <WordCloud {...(transformedProps as WordCloudProps)} /> - ), + render: props => <WordCloud {...(props as WordCloudProps)} />, }, );
