This is an automated email from the ASF dual-hosted git repository. aminghadersohi pushed a commit to branch work-pr-39604 in repository https://gitbox.apache.org/repos/asf/superset.git
commit 0e37e08eb12eaf43d95167487b9927dc16d12939 Author: Amin Ghadersohi <[email protected]> AuthorDate: Sat May 16 22:01:28 2026 +0000 fix(mcp): update security_manager patch target in RBAC tests Moving security_manager to a module-level import in auth.py means patch('superset.security_manager') no longer intercepts calls inside auth.py — the name is bound at import time. Patch where it is used: 'superset.mcp_service.auth.security_manager'. Co-Authored-By: Claude Sonnet 4.6 <[email protected]> --- tests/unit_tests/mcp_service/test_auth_rbac.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/unit_tests/mcp_service/test_auth_rbac.py b/tests/unit_tests/mcp_service/test_auth_rbac.py index 3949203282a..64a9684eaec 100644 --- a/tests/unit_tests/mcp_service/test_auth_rbac.py +++ b/tests/unit_tests/mcp_service/test_auth_rbac.py @@ -122,7 +122,7 @@ def test_check_tool_permission_granted(app_context) -> None: mock_sm = MagicMock() mock_sm.can_access = MagicMock(return_value=True) - with patch("superset.security_manager", mock_sm): + with patch("superset.mcp_service.auth.security_manager", mock_sm): result = check_tool_permission(func) assert result is True @@ -136,7 +136,7 @@ def test_check_tool_permission_denied(app_context) -> None: mock_sm = MagicMock() mock_sm.can_access = MagicMock(return_value=False) - with patch("superset.security_manager", mock_sm): + with patch("superset.mcp_service.auth.security_manager", mock_sm): result = check_tool_permission(func) assert result is False @@ -151,7 +151,7 @@ def test_check_tool_permission_default_method_is_read(app_context) -> None: mock_sm = MagicMock() mock_sm.can_access = MagicMock(return_value=True) - with patch("superset.security_manager", mock_sm): + with patch("superset.mcp_service.auth.security_manager", mock_sm): result = check_tool_permission(func) assert result is True
