This is an automated email from the ASF dual-hosted git repository. aminghadersohi pushed a commit to branch mcp-rls-plugins-99978 in repository https://gitbox.apache.org/repos/asf/superset.git
commit 336d30fbdcae87060574537228853532410c6ef5 Author: Amin Ghadersohi <[email protected]> AuthorDate: Wed May 27 15:20:37 2026 +0000 fix(mcp): correct serializer signatures and naming per review feedback - Fix `_serialize` in list_plugins and list_rls_filters: change `cols: list[str] | None` to `cols: list[str]` to match the `Callable[[T, List[str]], S | None]` signature expected by ModelListCore - Rename `_serialize` to `_serialize_rls_filter` in list_rls_filters for clarity and consistency with other list tool conventions --- superset/mcp_service/plugin/tool/list_plugins.py | 2 +- superset/mcp_service/rls/tool/list_rls_filters.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/superset/mcp_service/plugin/tool/list_plugins.py b/superset/mcp_service/plugin/tool/list_plugins.py index 8c5de9ec22f..f93821e507e 100644 --- a/superset/mcp_service/plugin/tool/list_plugins.py +++ b/superset/mcp_service/plugin/tool/list_plugins.py @@ -75,7 +75,7 @@ async def list_plugins( try: from superset.mcp_service.plugin.dao import DynamicPluginDAO - def _serialize(obj: object, cols: list[str] | None) -> PluginInfo | None: + def _serialize(obj: object, cols: list[str]) -> PluginInfo | None: return serialize_plugin_object(obj) list_tool = ModelListCore( diff --git a/superset/mcp_service/rls/tool/list_rls_filters.py b/superset/mcp_service/rls/tool/list_rls_filters.py index e72d032a96e..998033f90ad 100644 --- a/superset/mcp_service/rls/tool/list_rls_filters.py +++ b/superset/mcp_service/rls/tool/list_rls_filters.py @@ -75,13 +75,13 @@ async def list_rls_filters( try: from superset.daos.security import RLSDAO - def _serialize(obj: object, cols: list[str] | None) -> RlsFilterInfo | None: + def _serialize_rls_filter(obj: object, cols: list[str]) -> RlsFilterInfo | None: return serialize_rls_filter_object(obj) list_tool = ModelListCore( dao_class=RLSDAO, output_schema=RlsFilterInfo, - item_serializer=_serialize, + item_serializer=_serialize_rls_filter, filter_type=RlsColumnFilter, default_columns=DEFAULT_RLS_COLUMNS, search_columns=["name"],
