This is an automated email from the ASF dual-hosted git repository. aminghadersohi pushed a commit to branch oss-40340 in repository https://gitbox.apache.org/repos/asf/superset.git
commit de4da995b2cab0068b0b95c3c006071488060d7e Author: Amin Ghadersohi <[email protected]> AuthorDate: Thu May 14 20:19:17 2026 +0000 style: ruff format create_dataset tool files --- superset/mcp_service/dataset/schemas.py | 4 ++- .../dataset/tool/test_create_dataset.py | 32 +++++++--------------- 2 files changed, 13 insertions(+), 23 deletions(-) diff --git a/superset/mcp_service/dataset/schemas.py b/superset/mcp_service/dataset/schemas.py index 2b40eee7f34..d14b2fb4a11 100644 --- a/superset/mcp_service/dataset/schemas.py +++ b/superset/mcp_service/dataset/schemas.py @@ -291,7 +291,9 @@ class CreateDatasetRequest(BaseModel): database_id: Annotated[ int, - Field(description="ID of the database connection to register the table against"), + Field( + description="ID of the database connection to register the table against" + ), ] schema: Annotated[ str, diff --git a/tests/unit_tests/mcp_service/dataset/tool/test_create_dataset.py b/tests/unit_tests/mcp_service/dataset/tool/test_create_dataset.py index d129519f3f7..ae062f92346 100644 --- a/tests/unit_tests/mcp_service/dataset/tool/test_create_dataset.py +++ b/tests/unit_tests/mcp_service/dataset/tool/test_create_dataset.py @@ -87,9 +87,7 @@ def mock_auth(): class TestCreateDataset: """Tests for the create_dataset MCP tool.""" - @patch( - "superset.mcp_service.dataset.tool.create_dataset.CreateDatasetCommand" - ) + @patch("superset.mcp_service.dataset.tool.create_dataset.CreateDatasetCommand") @pytest.mark.asyncio async def test_create_dataset_success(self, mock_command_class, mcp_server): """Happy path: tool creates dataset and returns DatasetInfo.""" @@ -123,9 +121,7 @@ class TestCreateDataset: assert call_kwargs["table_name"] == "orders" assert "owners" not in call_kwargs - @patch( - "superset.mcp_service.dataset.tool.create_dataset.CreateDatasetCommand" - ) + @patch("superset.mcp_service.dataset.tool.create_dataset.CreateDatasetCommand") @pytest.mark.asyncio async def test_create_dataset_with_owners(self, mock_command_class, mcp_server): """Owners list is forwarded to the command when supplied.""" @@ -153,9 +149,7 @@ class TestCreateDataset: call_kwargs = mock_command_class.call_args[0][0] assert call_kwargs["owners"] == [5, 10] - @patch( - "superset.mcp_service.dataset.tool.create_dataset.CreateDatasetCommand" - ) + @patch("superset.mcp_service.dataset.tool.create_dataset.CreateDatasetCommand") @pytest.mark.asyncio async def test_create_dataset_already_exists(self, mock_command_class, mcp_server): """Returns DatasetError when a dataset for the table already exists.""" @@ -184,13 +178,9 @@ class TestCreateDataset: assert data["error_type"] == "DatasetExistsError" assert "error" in data - @patch( - "superset.mcp_service.dataset.tool.create_dataset.CreateDatasetCommand" - ) + @patch("superset.mcp_service.dataset.tool.create_dataset.CreateDatasetCommand") @pytest.mark.asyncio - async def test_create_dataset_table_not_found( - self, mock_command_class, mcp_server - ): + async def test_create_dataset_table_not_found(self, mock_command_class, mcp_server): """Returns DatasetError when the physical table does not exist in the DB.""" from superset.commands.dataset.exceptions import TableNotFoundValidationError from superset.sql.parse import Table @@ -216,9 +206,7 @@ class TestCreateDataset: data = json.loads(result.content[0].text) assert data["error_type"] == "TableNotFoundError" - @patch( - "superset.mcp_service.dataset.tool.create_dataset.CreateDatasetCommand" - ) + @patch("superset.mcp_service.dataset.tool.create_dataset.CreateDatasetCommand") @pytest.mark.asyncio async def test_create_dataset_unexpected_error( self, mock_command_class, mcp_server @@ -259,15 +247,15 @@ class TestCreateDataset: }, ) - @patch( - "superset.mcp_service.dataset.tool.create_dataset.CreateDatasetCommand" - ) + @patch("superset.mcp_service.dataset.tool.create_dataset.CreateDatasetCommand") @pytest.mark.asyncio async def test_create_dataset_returns_full_dataset_info( self, mock_command_class, mcp_server ): """The returned DatasetInfo includes columns, metrics, and all core fields.""" - mock_dataset = _make_mock_dataset(dataset_id=99, table_name="sales", schema="dw") + mock_dataset = _make_mock_dataset( + dataset_id=99, table_name="sales", schema="dw" + ) col = MagicMock() col.column_name = "amount"
