This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new c73106b7a28 fix(chart-echarts): drop white textBorder from Funnel
segment labels (#40468)
c73106b7a28 is described below
commit c73106b7a285f54dc9fc80826881c42bbf26c17d
Author: jesperct <[email protected]>
AuthorDate: Thu May 28 03:59:51 2026 -0300
fix(chart-echarts): drop white textBorder from Funnel segment labels
(#40468)
---
.../plugins/plugin-chart-echarts/src/Funnel/transformProps.ts | 2 --
.../plugin-chart-echarts/test/Funnel/transformProps.test.ts | 9 +++++++++
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git
a/superset-frontend/plugins/plugin-chart-echarts/src/Funnel/transformProps.ts
b/superset-frontend/plugins/plugin-chart-echarts/src/Funnel/transformProps.ts
index 87189c355a3..7c096da49dc 100644
---
a/superset-frontend/plugins/plugin-chart-echarts/src/Funnel/transformProps.ts
+++
b/superset-frontend/plugins/plugin-chart-echarts/src/Funnel/transformProps.ts
@@ -239,8 +239,6 @@ export default function transformProps(
formatter,
show: showLabels,
color: theme.colorText,
- textBorderColor: theme.colorBgBase,
- textBorderWidth: 1,
};
const legendData = keys.sort((a: string, b: string) => {
if (!legendSort) return 0;
diff --git
a/superset-frontend/plugins/plugin-chart-echarts/test/Funnel/transformProps.test.ts
b/superset-frontend/plugins/plugin-chart-echarts/test/Funnel/transformProps.test.ts
index b2e36c42bba..f2215b9ec52 100644
---
a/superset-frontend/plugins/plugin-chart-echarts/test/Funnel/transformProps.test.ts
+++
b/superset-frontend/plugins/plugin-chart-echarts/test/Funnel/transformProps.test.ts
@@ -72,6 +72,15 @@ describe('Funnel transformProps', () => {
}),
);
});
+
+ test('does not apply a text border to segment labels', () => {
+ // A white textBorder washes out the dark text on light-colored segments.
+ const result = transformProps(chartProps as EchartsFunnelChartProps);
+ const { label } = (result.echartOptions.series as any)[0];
+ expect(label.color).toBe(supersetTheme.colorText);
+ expect(label.textBorderColor).toBeUndefined();
+ expect(label.textBorderWidth).toBeUndefined();
+ });
});
describe('formatFunnelLabel', () => {
