This is an automated email from the ASF dual-hosted git repository.

rusackas pushed a commit to branch SO-164
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 706650dac51a56f172b5e638c6cd79eab48dd2cf
Author: Evan Rusackas <[email protected]>
AuthorDate: Sat Jul 11 11:01:11 2026 -0700

    fix(databases): stop leaking renderAsTextArea/textAreaCss onto the DOM
    
    LabeledErrorBoundInput spread these two props onto StyledTextArea (an
    Input.TextArea, i.e. a real <textarea>), so React logged "unknown prop"
    warnings. Destructure them out of the rest props and reference the named
    values directly.
    
    Co-Authored-By: Claude Opus 4.8 <[email protected]>
---
 .../src/components/Form/LabeledErrorBoundInput.tsx             | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git 
a/superset-frontend/packages/superset-ui-core/src/components/Form/LabeledErrorBoundInput.tsx
 
b/superset-frontend/packages/superset-ui-core/src/components/Form/LabeledErrorBoundInput.tsx
index 5d23490f9b1..cfe59254f9f 100644
--- 
a/superset-frontend/packages/superset-ui-core/src/components/Form/LabeledErrorBoundInput.tsx
+++ 
b/superset-frontend/packages/superset-ui-core/src/components/Form/LabeledErrorBoundInput.tsx
@@ -66,6 +66,8 @@ export const LabeledErrorBoundInput = ({
   get_url,
   description,
   isValidating = false,
+  renderAsTextArea,
+  textAreaCss,
   ...props
 }: LabeledErrorBoundInputProps) => {
   const hasError = !!errorMessage;
@@ -102,12 +104,8 @@ export const LabeledErrorBoundInput = ({
             }
             role="textbox"
           />
-        ) : props.renderAsTextArea ? (
-          <StyledTextArea
-            css={props.textAreaCss}
-            {...props}
-            {...validationMethods}
-          />
+        ) : renderAsTextArea ? (
+          <StyledTextArea css={textAreaCss} {...props} {...validationMethods} 
/>
         ) : (
           <StyledInput {...props} {...validationMethods} />
         )}

Reply via email to