This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new e8521471820 test: add edge-case tests for datetime_to_epoch function
(#39404)
e8521471820 is described below
commit e852147182037cb8bf21ccd8d54e7561ccab50b7
Author: Krupa Vadher <[email protected]>
AuthorDate: Sat Jul 11 11:51:46 2026 -0700
test: add edge-case tests for datetime_to_epoch function (#39404)
Co-authored-by: Evan <[email protected]>
Co-authored-by: Claude Opus 4.8 <[email protected]>
Co-authored-by: Evan Rusackas <[email protected]>
---
tests/unit_tests/utils/test_date_parsing.py | 91 +++++++++++++++++++++++++++++
1 file changed, 91 insertions(+)
diff --git a/tests/unit_tests/utils/test_date_parsing.py
b/tests/unit_tests/utils/test_date_parsing.py
index 824ff15c429..685eaf43906 100644
--- a/tests/unit_tests/utils/test_date_parsing.py
+++ b/tests/unit_tests/utils/test_date_parsing.py
@@ -17,11 +17,14 @@
"""Tests for datetime format detection and warning suppression."""
import warnings
+from datetime import datetime
import pandas as pd
import pytest
+import pytz
from superset.utils.core import DateColumn, normalize_dttm_col
+from superset.utils.dates import datetime_to_epoch
from superset.utils.pandas import detect_datetime_format
@@ -254,3 +257,91 @@ def test_warning_suppression():
assert len(warnings_list) == 0 # Should suppress all format inference
warnings
assert pd.api.types.is_datetime64_any_dtype(df["date"]) # Should still
parse dates
+
+
+# ============================================================================
+# NEW TESTS FOR datetime_to_epoch() - Edge case coverage
+# ============================================================================
+
+
+def test_datetime_to_epoch_naive_at_epoch():
+ """Test naive datetime exactly at epoch returns 0.0"""
+ # Edge case: Datetime at epoch boundary
+ epoch_dt = datetime(1970, 1, 1, 0, 0, 0)
+ result = datetime_to_epoch(epoch_dt)
+ assert result == 0.0, f"Epoch datetime should be 0.0, got {result}"
+
+
+def test_datetime_to_epoch_naive_one_second_after():
+ """Test naive datetime 1 second after epoch"""
+ dt = datetime(1970, 1, 1, 0, 0, 1)
+ result = datetime_to_epoch(dt)
+ expected = 1000.0 # 1 second * 1000 ms
+ assert result == expected, f"Expected {expected}ms, got {result}ms"
+
+
+def test_datetime_to_epoch_timezone_aware_utc():
+ """Test timezone-aware datetime in UTC"""
+ # Create UTC datetime
+ utc_tz = pytz.UTC
+ dt_utc = utc_tz.localize(datetime(1970, 1, 1, 0, 0, 1))
+ result = datetime_to_epoch(dt_utc)
+ expected = 1000.0 # 1 second * 1000 ms
+ assert result == expected, f"UTC datetime should convert correctly, got
{result}ms"
+
+
+def test_datetime_to_epoch_timezone_aware_different_tz():
+ """Test timezone-aware datetime in different timezone converts to UTC
correctly"""
+ # Create datetime in EST (UTC-5 in January)
+ est = pytz.timezone("US/Eastern")
+ # 1970-01-01 05:00:00 EST = 1970-01-01 10:00:00 UTC (5 hours offset)
+ dt_est = est.localize(datetime(1970, 1, 1, 5, 0, 0))
+ result = datetime_to_epoch(dt_est)
+ expected = 10 * 60 * 60 * 1000 # 10 hours in milliseconds
+ assert result == expected, (
+ f"EST datetime should convert to UTC correctly, got {result}ms"
+ )
+
+
+def test_datetime_to_epoch_dst_transition():
+ """Test datetime during DST transition is handled correctly"""
+ # Use a known DST transition date in US/Eastern
+ # 2023-03-12: Spring forward (2 AM becomes 3 AM, gap of 1 hour)
+ eastern = pytz.timezone("US/Eastern")
+
+ # Create datetime before DST transition (still EST, standard time)
+ dt_before_dst = eastern.localize(datetime(2023, 3, 12, 1, 59, 59),
is_dst=False)
+ result_before = datetime_to_epoch(dt_before_dst)
+
+ # Create datetime after DST transition (now EDT, daylight time)
+ dt_after_dst = eastern.localize(datetime(2023, 3, 12, 3, 0, 1),
is_dst=True)
+ result_after = datetime_to_epoch(dt_after_dst)
+
+ # The difference should be exactly 2 seconds, not 1 hour + 2 seconds
+ # (because of the DST jump, 1:59:59 EST -> 3:00:01 EDT)
+ diff_ms = result_after - result_before
+ expected_diff = 2000 # 2 seconds
+ assert diff_ms == expected_diff, (
+ f"DST transition handled incorrectly. Diff: {diff_ms}ms"
+ )
+
+
+def test_datetime_to_epoch_microsecond_precision():
+ """Test that microseconds are handled correctly"""
+ dt = datetime(1970, 1, 1, 0, 0, 1, 500000) # 1.5 seconds
+ result = datetime_to_epoch(dt)
+ expected = 1500.0 # 1.5 seconds * 1000 ms
+ assert result == expected, (
+ f"Microseconds should contribute to result, got {result}ms"
+ )
+
+
+def test_datetime_to_epoch_far_future():
+ """Test datetime far in the future"""
+ # 2050-01-01 should work without errors
+ dt = datetime(2050, 1, 1, 0, 0, 0)
+ result = datetime_to_epoch(dt)
+ # Just verify it's a reasonable large number (no crashes, reasonable value)
+ assert isinstance(result, float), "Should return float"
+ assert result > 0, "Far future date should have positive epoch"
+ assert result == 2524608000000.0, "2050-01-01 should be specific epoch
value"
