This is an automated email from the ASF dual-hosted git repository.

eschutho pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 0ecf34d80e1 fix(a11y): add aria-label to ViewportControl text inputs 
(#41931)
0ecf34d80e1 is described below

commit 0ecf34d80e1c45b88beae0ecca0c6e1cbe98bcb8
Author: Elizabeth Thompson <[email protected]>
AuthorDate: Sat Jul 11 15:02:44 2026 -0700

    fix(a11y): add aria-label to ViewportControl text inputs (#41931)
---
 .../src/explore/components/controls/TextControl/index.tsx             | 4 +++-
 superset-frontend/src/explore/components/controls/ViewportControl.tsx | 1 +
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git 
a/superset-frontend/src/explore/components/controls/TextControl/index.tsx 
b/superset-frontend/src/explore/components/controls/TextControl/index.tsx
index 3e238658b40..710c0632c7a 100644
--- a/superset-frontend/src/explore/components/controls/TextControl/index.tsx
+++ b/superset-frontend/src/explore/components/controls/TextControl/index.tsx
@@ -27,6 +27,7 @@ type InputValueType = string | number;
 export interface TextControlProps<T extends InputValueType = InputValueType> {
   name?: string;
   label?: string;
+  ariaLabel?: string;
   description?: string;
   disabled?: boolean;
   isFloat?: boolean;
@@ -48,6 +49,7 @@ const safeStringify = (value?: InputValueType | null) =>
 function TextControl<T extends InputValueType = InputValueType>({
   name,
   label,
+  ariaLabel,
   description,
   disabled,
   isFloat,
@@ -143,7 +145,7 @@ function TextControl<T extends InputValueType = 
InputValueType>({
         onFocus={onFocus}
         value={displayValue}
         disabled={disabled}
-        aria-label={label}
+        aria-label={ariaLabel ?? label}
       />
     </div>
   );
diff --git 
a/superset-frontend/src/explore/components/controls/ViewportControl.tsx 
b/superset-frontend/src/explore/components/controls/ViewportControl.tsx
index 43255829e40..dd1ea4ccd12 100644
--- a/superset-frontend/src/explore/components/controls/ViewportControl.tsx
+++ b/superset-frontend/src/explore/components/controls/ViewportControl.tsx
@@ -78,6 +78,7 @@ export default function ViewportControl({
         value={value?.[ctrl]}
         onChange={(ctrlValue: number) => handleChange(ctrl, ctrlValue)}
         isFloat
+        ariaLabel={ctrl}
       />
     </div>
   );

Reply via email to