This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new c762b75ddc5 chore(lint): upgrade no-unused-vars rule from warn to
error (#41132)
c762b75ddc5 is described below
commit c762b75ddc5a614bca28ca845f5b46f373fc00d1
Author: Evan Rusackas <[email protected]>
AuthorDate: Mon Jul 13 03:11:09 2026 -0700
chore(lint): upgrade no-unused-vars rule from warn to error (#41132)
Co-authored-by: Superset Dev <[email protected]>
Co-authored-by: Claude Fable 5 <[email protected]>
---
superset-frontend/.storybook/preview.jsx | 2 +-
superset-frontend/oxlint.json | 9 ++++++++-
.../src/chart/components/Matrixify/MatrixifyGridCell.tsx | 2 +-
.../chart/components/Matrixify/MatrixifyGridRenderer.tsx | 3 +--
.../superset-ui-core/src/components/Label/index.tsx | 2 +-
.../src/components/TimezoneSelector/index.tsx | 2 +-
.../plugins/legacy-plugin-chart-calendar/src/Calendar.ts | 2 +-
.../legacy-plugin-chart-country-map/src/CountryMap.ts | 2 +-
.../plugin-chart-ag-grid-table/src/AgGridTableChart.tsx | 1 -
.../src/renderers/NumericCellRenderer.tsx | 16 +---------------
.../plugin-chart-ag-grid-table/src/utils/useColDefs.ts | 4 +---
.../plugin-chart-echarts/src/BigNumber/BigNumberViz.tsx | 4 ----
.../src/Timeseries/Regular/Bar/controlPanel.tsx | 9 ++-------
.../plugins/plugin-chart-table/src/TableChart.tsx | 8 +-------
.../components/TableExploreTree/TreeNodeRenderer.tsx | 1 -
superset-frontend/src/components/Chart/ChartRenderer.tsx | 1 -
.../Datasource/FoldersEditor/TreeItem.styles.ts | 2 +-
.../components/DatasourceEditor/DatasourceEditor.tsx | 9 ---------
.../ErrorMessage/FrontendNetworkErrorMessage.tsx | 1 -
superset-frontend/src/components/GridTable/index.tsx | 1 -
.../src/components/Modal/CollapsibleModalSection.tsx | 2 --
.../src/components/Modal/ModalFormField.tsx | 4 ----
superset-frontend/src/components/Modal/StandardModal.tsx | 6 ------
superset-frontend/src/components/Tag/utils.test.tsx | 2 +-
superset-frontend/src/core/sqlLab/models.ts | 4 ++--
superset-frontend/src/dashboard/components/Dashboard.tsx | 4 ----
superset-frontend/src/dashboard/components/SaveModal.tsx | 8 ++++----
.../components/gridComponents/Divider/Divider.test.tsx | 2 +-
.../gridComponents/TabsRenderer/TabsRenderer.tsx | 2 --
.../FilterBar/FilterControls/FilterControls.tsx | 2 +-
.../components/nativeFilters/FilterBar/Vertical.tsx | 2 --
.../hooks/useCustomizationOperations.ts | 2 +-
.../FiltersConfigModal/hooks/useFilterOperations.ts | 2 +-
.../components/DataTablesPane/components/SamplesPane.tsx | 1 -
.../src/explore/components/ExploreAlert.tsx | 2 +-
.../explore/components/ExploreViewContainer/index.tsx | 7 +++++--
.../components/controls/DatasourceControl/index.tsx | 1 -
.../FilterControl/AdhocFilterEditPopover/index.tsx | 2 +-
.../explore/components/controls/TextControl/index.tsx | 3 ---
.../src/features/alerts/AlertReportModal.tsx | 2 +-
.../features/alerts/components/NotificationMethod.tsx | 2 +-
.../src/features/allEntities/AllEntitiesTable.tsx | 2 +-
.../src/features/annotations/AnnotationModal.tsx | 2 +-
.../src/features/databases/DatabaseModal/index.test.tsx | 2 +-
.../src/features/databases/UploadDataModel/index.tsx | 4 ++--
.../src/features/roles/RoleListEditModal.test.tsx | 2 +-
superset-frontend/src/features/tags/BulkTagModal.tsx | 2 +-
superset-frontend/src/features/tags/TagModal.tsx | 2 +-
.../src/features/userInfo/UserInfoModal.tsx | 2 +-
superset-frontend/src/features/users/utils.ts | 2 +-
superset-frontend/src/pages/AllEntities/index.tsx | 4 ++--
.../src/pages/ChartList/ChartList.permissions.test.tsx | 6 +++---
.../DashboardList/DashboardList.permissions.test.tsx | 7 ++++---
superset-frontend/src/pages/GroupsList/index.tsx | 2 +-
superset-frontend/src/pages/UsersList/index.tsx | 2 +-
superset-frontend/src/setup/setupCodeOverrides.ts | 4 +++-
superset-frontend/src/theme/ThemeController.ts | 7 +++----
57 files changed, 68 insertions(+), 127 deletions(-)
diff --git a/superset-frontend/.storybook/preview.jsx
b/superset-frontend/.storybook/preview.jsx
index 4339552bac7..84a54ba2087 100644
--- a/superset-frontend/.storybook/preview.jsx
+++ b/superset-frontend/.storybook/preview.jsx
@@ -22,7 +22,7 @@ import thunk from 'redux-thunk';
import { Provider } from 'react-redux';
import reducerIndex from 'spec/helpers/reducerIndex';
import { Global } from '@emotion/react';
-import { App, Layout, Space, Content } from 'antd';
+import { App, Layout } from 'antd';
import 'src/theme.ts';
import './storybook.css';
diff --git a/superset-frontend/oxlint.json b/superset-frontend/oxlint.json
index 7812bbfe6a9..27563d81c5e 100644
--- a/superset-frontend/oxlint.json
+++ b/superset-frontend/oxlint.json
@@ -232,7 +232,14 @@
"@typescript-eslint/no-non-null-assertion": "off",
"@typescript-eslint/explicit-function-return-type": "off",
"@typescript-eslint/explicit-module-boundary-types": "off",
- "@typescript-eslint/no-unused-vars": "warn",
+ "@typescript-eslint/no-unused-vars": [
+ "error",
+ {
+ "argsIgnorePattern": "^_",
+ "varsIgnorePattern": "^_",
+ "caughtErrors": "none"
+ }
+ ],
"@typescript-eslint/prefer-optional-chain": "error",
// === Unicorn rules (bonus coverage) ===
diff --git
a/superset-frontend/packages/superset-ui-core/src/chart/components/Matrixify/MatrixifyGridCell.tsx
b/superset-frontend/packages/superset-ui-core/src/chart/components/Matrixify/MatrixifyGridCell.tsx
index 5a808378c84..ddcb7a8d86c 100644
---
a/superset-frontend/packages/superset-ui-core/src/chart/components/Matrixify/MatrixifyGridCell.tsx
+++
b/superset-frontend/packages/superset-ui-core/src/chart/components/Matrixify/MatrixifyGridCell.tsx
@@ -92,7 +92,7 @@ const MatrixNoDataComponent = () => {
* Individual grid cell component - memoized to prevent unnecessary re-renders
*/
const MatrixifyGridCell = memo(
- ({ cell, rowHeight, datasource, hooks }: MatrixifyGridCellProps) => {
+ ({ cell, hooks }: MatrixifyGridCellProps) => {
// Use computed title from template (will be empty string if no template)
const cellLabel = cell.title || '';
diff --git
a/superset-frontend/packages/superset-ui-core/src/chart/components/Matrixify/MatrixifyGridRenderer.tsx
b/superset-frontend/packages/superset-ui-core/src/chart/components/Matrixify/MatrixifyGridRenderer.tsx
index fc4b6422459..4882ce85163 100644
---
a/superset-frontend/packages/superset-ui-core/src/chart/components/Matrixify/MatrixifyGridRenderer.tsx
+++
b/superset-frontend/packages/superset-ui-core/src/chart/components/Matrixify/MatrixifyGridRenderer.tsx
@@ -118,7 +118,6 @@ interface MatrixifyGridRendererProps {
function MatrixifyGridRenderer({
formData,
datasource,
- width,
height,
hooks,
}: MatrixifyGridRendererProps) {
@@ -249,7 +248,7 @@ function MatrixifyGridRenderer({
{/* Row cells for this column group */}
{row
.slice(colGroup.startIdx, colGroup.endIdx)
- .map((cell, colIdx) =>
+ .map(cell =>
cell ? (
<MatrixifyGridCell
key={cell.id}
diff --git
a/superset-frontend/packages/superset-ui-core/src/components/Label/index.tsx
b/superset-frontend/packages/superset-ui-core/src/components/Label/index.tsx
index a53ea7e9c83..a43f01da65f 100644
--- a/superset-frontend/packages/superset-ui-core/src/components/Label/index.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/Label/index.tsx
@@ -34,7 +34,7 @@ export const Label = forwardRef<HTMLSpanElement,
LabelProps>((props, ref) => {
onClick,
children,
icon,
- id,
+ id: _id,
...rest
} = props;
diff --git
a/superset-frontend/packages/superset-ui-core/src/components/TimezoneSelector/index.tsx
b/superset-frontend/packages/superset-ui-core/src/components/TimezoneSelector/index.tsx
index e2fb7e55d60..d9ff01a8ce3 100644
---
a/superset-frontend/packages/superset-ui-core/src/components/TimezoneSelector/index.tsx
+++
b/superset-frontend/packages/superset-ui-core/src/components/TimezoneSelector/index.tsx
@@ -67,7 +67,7 @@ function findMatchingTimezone(
export default function TimezoneSelector({
onTimezoneChange,
timezone,
- minWidth = MIN_SELECT_WIDTH,
+ minWidth: _minWidth = MIN_SELECT_WIDTH,
placeholder,
...rest
}: TimezoneSelectorProps) {
diff --git
a/superset-frontend/plugins/legacy-plugin-chart-calendar/src/Calendar.ts
b/superset-frontend/plugins/legacy-plugin-chart-calendar/src/Calendar.ts
index 794959fe7c4..a36d6a2648c 100644
--- a/superset-frontend/plugins/legacy-plugin-chart-calendar/src/Calendar.ts
+++ b/superset-frontend/plugins/legacy-plugin-chart-calendar/src/Calendar.ts
@@ -112,7 +112,7 @@ function Calendar(element: HTMLElement, props:
CalendarProps) {
const colorScheme = getSequentialSchemeRegistry().get(linearColorScheme);
const colorScale = colorScheme
? colorScheme.createLinearScale(extents)
- : (v: number) => '#ccc'; // fallback if scheme not found
+ : (_v: number) => '#ccc'; // fallback if scheme not found
const legend = d3Range(steps).map(i => extents[0] + step * i);
const legendColors = legend.map(x => colorScale(x));
diff --git
a/superset-frontend/plugins/legacy-plugin-chart-country-map/src/CountryMap.ts
b/superset-frontend/plugins/legacy-plugin-chart-country-map/src/CountryMap.ts
index a8bbb04d0ac..048f92c7a81 100644
---
a/superset-frontend/plugins/legacy-plugin-chart-country-map/src/CountryMap.ts
+++
b/superset-frontend/plugins/legacy-plugin-chart-country-map/src/CountryMap.ts
@@ -151,7 +151,7 @@ function CountryMap(element: HTMLElement, props:
CountryMapProps) {
if (!isEditMode) {
svg.style('cursor', 'grab');
}
- const backgroundRect = svg
+ svg
.append('rect')
.attr('class', 'background')
.attr('width', width)
diff --git
a/superset-frontend/plugins/plugin-chart-ag-grid-table/src/AgGridTableChart.tsx
b/superset-frontend/plugins/plugin-chart-ag-grid-table/src/AgGridTableChart.tsx
index 33a73698ea8..01c7a28cc1e 100644
---
a/superset-frontend/plugins/plugin-chart-ag-grid-table/src/AgGridTableChart.tsx
+++
b/superset-frontend/plugins/plugin-chart-ag-grid-table/src/AgGridTableChart.tsx
@@ -271,7 +271,6 @@ export default function TableChart<D extends DataRecord =
DataRecord>(
defaultAlignPN: alignPositiveNegative,
showCellBars,
colorPositiveNegative,
- totals,
columnColorFormatters,
allowRearrangeColumns,
basicColorFormatters,
diff --git
a/superset-frontend/plugins/plugin-chart-ag-grid-table/src/renderers/NumericCellRenderer.tsx
b/superset-frontend/plugins/plugin-chart-ag-grid-table/src/renderers/NumericCellRenderer.tsx
index 11d40569065..349df06191c 100644
---
a/superset-frontend/plugins/plugin-chart-ag-grid-table/src/renderers/NumericCellRenderer.tsx
+++
b/superset-frontend/plugins/plugin-chart-ag-grid-table/src/renderers/NumericCellRenderer.tsx
@@ -16,14 +16,9 @@
* specific language governing permissions and limitations
* under the License.
*/
-import {
- styled,
- useTheme,
- type SupersetTheme,
-} from '@apache-superset/core/theme';
+import { styled } from '@apache-superset/core/theme';
import { CustomCellRendererProps } from
'@superset-ui/core/components/ThemedAgGridReact';
import { BasicColorFormatterType, InputColumn, ValueRange } from '../types';
-import { useIsDark } from '../utils/useTableTheme';
import getRowBasicColorFormatter from '../utils/getRowBasicColorFormatter';
const StyledTotalCell = styled.div`
@@ -111,13 +106,9 @@ function cellOffset({
function cellBackground({
value,
colorPositiveNegative = false,
- isDarkTheme = false,
- theme,
}: {
value: number;
colorPositiveNegative: boolean;
- isDarkTheme: boolean;
- theme: SupersetTheme | null;
}) {
if (!colorPositiveNegative) {
return 'transparent'; // Use transparent background when
colorPositiveNegative is false
@@ -154,9 +145,6 @@ export const NumericCellRenderer = (
colorPositiveNegative,
} = params;
- const isDarkTheme = useIsDark();
- const theme = !colorPositiveNegative ? null : useTheme();
-
if (node?.rowPinned === 'bottom') {
return <StyledTotalCell>{valueFormatted ?? value}</StyledTotalCell>;
}
@@ -200,8 +188,6 @@ export const NumericCellRenderer = (
const background = cellBackground({
value: value as number,
colorPositiveNegative,
- isDarkTheme,
- theme,
});
return (
diff --git
a/superset-frontend/plugins/plugin-chart-ag-grid-table/src/utils/useColDefs.ts
b/superset-frontend/plugins/plugin-chart-ag-grid-table/src/utils/useColDefs.ts
index d216165f8d1..31dbae2ce9a 100644
---
a/superset-frontend/plugins/plugin-chart-ag-grid-table/src/utils/useColDefs.ts
+++
b/superset-frontend/plugins/plugin-chart-ag-grid-table/src/utils/useColDefs.ts
@@ -20,7 +20,7 @@
import { t } from '@apache-superset/core/translation';
import { ColDef } from '@superset-ui/core/components/ThemedAgGridReact';
import { useCallback, useMemo } from 'react';
-import { DataRecord, DataRecordValue, JsonObject } from '@superset-ui/core';
+import { DataRecordValue, JsonObject } from '@superset-ui/core';
import { GenericDataType } from '@apache-superset/core/common';
import { useTheme } from '@apache-superset/core/theme';
import { ColorFormatters } from '@superset-ui/chart-controls';
@@ -61,7 +61,6 @@ type UseColDefsProps = {
defaultAlignPN: boolean;
showCellBars: boolean;
colorPositiveNegative: boolean;
- totals: DataRecord | undefined;
columnColorFormatters: ColorFormatters;
allowRearrangeColumns?: boolean;
basicColorFormatters?: { [Key: string]: BasicColorFormatterType }[];
@@ -227,7 +226,6 @@ export const useColDefs = ({
defaultAlignPN,
showCellBars,
colorPositiveNegative,
- totals,
columnColorFormatters,
allowRearrangeColumns,
basicColorFormatters,
diff --git
a/superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberViz.tsx
b/superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberViz.tsx
index 25c2774d825..dc7d3cd2e85 100644
---
a/superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberViz.tsx
+++
b/superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberViz.tsx
@@ -23,7 +23,6 @@ import {
getTimeFormatter,
SMART_DATE_VERBOSE_ID,
computeMaxFontSize,
- BRAND_COLOR,
BinaryQueryObjectFilterClause,
DTTM_ALIAS,
} from '@superset-ui/core';
@@ -43,14 +42,11 @@ function BigNumberVis({
kickerFontSize = PROPORTION.KICKER,
metricNameFontSize = PROPORTION.METRIC_NAME,
showMetricName = true,
- mainColor = BRAND_COLOR,
showTimestamp = false,
showTrendLine = false,
- startYAxisAtZero = true,
subheader = '',
subheaderFontSize = PROPORTION.SUBHEADER,
subtitleFontSize = PROPORTION.SUBHEADER,
- timeRangeFixed = false,
...props
}: BigNumberVizProps) {
const theme = useTheme();
diff --git
a/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Bar/controlPanel.tsx
b/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Bar/controlPanel.tsx
index cd77a0a44d2..fe05cb055c5 100644
---
a/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Bar/controlPanel.tsx
+++
b/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Bar/controlPanel.tsx
@@ -371,13 +371,8 @@ const config: ControlPanelConfig = {
description: t(
'Stack in groups, where each group corresponds to a dimension',
),
- shouldMapStateToProps: (
- prevState,
- state,
- controlState,
- chartState,
- ) => true,
- mapStateToProps: (state, controlState, chartState) => {
+ shouldMapStateToProps: () => true,
+ mapStateToProps: state => {
const value: JsonArray = ensureIsArray(
state.controls.groupby?.value,
) as JsonArray;
diff --git a/superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx
b/superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx
index 43293e54c79..ed82329649a 100644
--- a/superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx
+++ b/superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx
@@ -265,13 +265,7 @@ const VisuallyHidden = styled.label`
border: 0;
`;
-function SearchInput({
- count,
- value,
- onChange,
- onBlur,
- inputRef,
-}: SearchInputProps) {
+function SearchInput({ value, onChange, onBlur, inputRef }: SearchInputProps) {
return (
<Space direction="vertical" size={4} className="dt-global-filter">
<span aria-hidden="true">{t('Search')}</span>
diff --git
a/superset-frontend/src/SqlLab/components/TableExploreTree/TreeNodeRenderer.tsx
b/superset-frontend/src/SqlLab/components/TableExploreTree/TreeNodeRenderer.tsx
index 52c1dca2f0d..5e0eb6c60d2 100644
---
a/superset-frontend/src/SqlLab/components/TableExploreTree/TreeNodeRenderer.tsx
+++
b/superset-frontend/src/SqlLab/components/TableExploreTree/TreeNodeRenderer.tsx
@@ -101,7 +101,6 @@ export interface TreeNodeRendererProps extends
NodeRendererProps<TreeNodeData> {
const TreeNodeRenderer: React.FC<TreeNodeRendererProps> = ({
node,
style,
- manuallyOpenedNodes,
loadingNodes,
searchTerm,
catalog,
diff --git a/superset-frontend/src/components/Chart/ChartRenderer.tsx
b/superset-frontend/src/components/Chart/ChartRenderer.tsx
index 52f0d3a4d9d..65be71c5aff 100644
--- a/superset-frontend/src/components/Chart/ChartRenderer.tsx
+++ b/superset-frontend/src/components/Chart/ChartRenderer.tsx
@@ -183,7 +183,6 @@ function ChartRendererComponent({
onFilterMenuClose = () => BLANK,
initialValues = BLANK,
setControlValue = () => {},
- triggerRender = false,
...restProps
}: ChartRendererProps): JSX.Element | null {
const {
diff --git
a/superset-frontend/src/components/Datasource/FoldersEditor/TreeItem.styles.ts
b/superset-frontend/src/components/Datasource/FoldersEditor/TreeItem.styles.ts
index 1f3d79a5258..03a39969648 100644
---
a/superset-frontend/src/components/Datasource/FoldersEditor/TreeItem.styles.ts
+++
b/superset-frontend/src/components/Datasource/FoldersEditor/TreeItem.styles.ts
@@ -71,7 +71,7 @@ export const ItemSeparator = styled.div<{
export const TreeFolderContainer = styled(TreeItemContainer)<{
isForbiddenDropTarget?: boolean;
}>`
- ${({ theme, depth, isForbiddenDropTarget, isOverlay }) => `
+ ${({ theme, depth, isForbiddenDropTarget }) => `
margin-top: 0;
margin-bottom: 0;
padding-top: ${theme.paddingSM}px;
diff --git
a/superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.tsx
b/superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.tsx
index 775212a8b90..7f12f00eb02 100644
---
a/superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.tsx
+++
b/superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.tsx
@@ -276,9 +276,7 @@ interface CollectionTabTitleProps {
interface ColumnCollectionTableProps {
columns: Column[];
- datasource: DatasourceObject;
onColumnsChange: (columns: Column[]) => void;
- onDatasourceChange: (datasource: DatasourceObject) => void;
editableColumnName?: boolean;
showExpression?: boolean;
allowAddItem?: boolean;
@@ -493,9 +491,7 @@ function FormContainer({ children }: FormContainerProps):
JSX.Element {
function ColumnCollectionTable({
columns,
- datasource,
onColumnsChange,
- onDatasourceChange,
editableColumnName = false,
showExpression = false,
allowAddItem = false,
@@ -2416,9 +2412,7 @@ function DatasourceEditor({
columns={databaseColumns}
filterTerm={columnSearchTerm}
filterFields={['column_name']}
- datasource={datasource}
onColumnsChange={cols => setColumns({ databaseColumns: cols })}
- onDatasourceChange={onDatasourceChange}
/>
{metadataLoading && <Loading />}
</StyledTableTabWrapper>
@@ -2457,8 +2451,6 @@ function DatasourceEditor({
'as the alias in the SQL query.',
),
}}
- onDatasourceChange={onDatasourceChange}
- datasource={datasource}
editableColumnName
showExpression
allowAddItem
@@ -2544,7 +2536,6 @@ function DatasourceEditor({
isEditMode,
datasource,
setColumns,
- onDatasourceChange,
metadataLoading,
calculatedColumns,
columnSearchTerm,
diff --git
a/superset-frontend/src/components/ErrorMessage/FrontendNetworkErrorMessage.tsx
b/superset-frontend/src/components/ErrorMessage/FrontendNetworkErrorMessage.tsx
index 899e332410c..486894b4be7 100644
---
a/superset-frontend/src/components/ErrorMessage/FrontendNetworkErrorMessage.tsx
+++
b/superset-frontend/src/components/ErrorMessage/FrontendNetworkErrorMessage.tsx
@@ -23,7 +23,6 @@ import { ErrorAlert } from './ErrorAlert';
export function FrontendNetworkErrorMessage({
error,
- subtitle,
compact,
closable,
}: ErrorMessageComponentProps) {
diff --git a/superset-frontend/src/components/GridTable/index.tsx
b/superset-frontend/src/components/GridTable/index.tsx
index b54f6b47545..b071f5ae81c 100644
--- a/superset-frontend/src/components/GridTable/index.tsx
+++ b/superset-frontend/src/components/GridTable/index.tsx
@@ -45,7 +45,6 @@ export function GridTable<RecordType extends object>({
showRowNumber,
enableActions,
size = GridSize.Middle,
- striped,
themeOverrides,
}: TableProps<RecordType>) {
const theme = useTheme();
diff --git a/superset-frontend/src/components/Modal/CollapsibleModalSection.tsx
b/superset-frontend/src/components/Modal/CollapsibleModalSection.tsx
index cad4424ed1a..a27349464f6 100644
--- a/superset-frontend/src/components/Modal/CollapsibleModalSection.tsx
+++ b/superset-frontend/src/components/Modal/CollapsibleModalSection.tsx
@@ -24,7 +24,6 @@ interface CollapsibleModalSectionProps {
sectionKey: string;
title: string;
subtitle?: string;
- defaultExpanded?: boolean;
hasErrors?: boolean;
testId?: string;
children: ReactNode;
@@ -41,7 +40,6 @@ export function CollapsibleModalSection({
sectionKey,
title,
subtitle,
- defaultExpanded = false,
hasErrors = false,
testId,
children,
diff --git a/superset-frontend/src/components/Modal/ModalFormField.tsx
b/superset-frontend/src/components/Modal/ModalFormField.tsx
index c825e465b58..7012379b4f5 100644
--- a/superset-frontend/src/components/Modal/ModalFormField.tsx
+++ b/superset-frontend/src/components/Modal/ModalFormField.tsx
@@ -29,8 +29,6 @@ interface ModalFormFieldProps {
bottomSpacing?: boolean;
children: ReactNode;
testId?: string;
- validateStatus?: 'success' | 'warning' | 'error' | 'validating';
- hasFeedback?: boolean;
}
const StyledFieldContainer = styled.div<{ bottomSpacing: boolean }>`
@@ -125,8 +123,6 @@ export function ModalFormField({
bottomSpacing = true,
children,
testId,
- validateStatus,
- hasFeedback = false,
}: ModalFormFieldProps) {
return (
<StyledFieldContainer bottomSpacing={bottomSpacing} data-test={testId}>
diff --git a/superset-frontend/src/components/Modal/StandardModal.tsx
b/superset-frontend/src/components/Modal/StandardModal.tsx
index 963afdbca53..a74f130d4d1 100644
--- a/superset-frontend/src/components/Modal/StandardModal.tsx
+++ b/superset-frontend/src/components/Modal/StandardModal.tsx
@@ -32,13 +32,10 @@ interface StandardModalProps {
saveDisabled?: boolean;
saveLoading?: boolean;
saveText?: string;
- cancelText?: string;
errorTooltip?: ReactNode;
children: ReactNode;
isEditMode?: boolean;
centered?: boolean;
- destroyOnClose?: boolean;
- maskClosable?: boolean;
wrapProps?: object;
contentLoading?: boolean;
}
@@ -107,13 +104,10 @@ export function StandardModal({
saveDisabled = false,
saveLoading = false,
saveText,
- cancelText,
errorTooltip,
children,
isEditMode = false,
centered = true,
- destroyOnClose = true,
- maskClosable = false,
wrapProps,
contentLoading = false,
}: StandardModalProps) {
diff --git a/superset-frontend/src/components/Tag/utils.test.tsx
b/superset-frontend/src/components/Tag/utils.test.tsx
index 19b41159084..eaf1c87c331 100644
--- a/superset-frontend/src/components/Tag/utils.test.tsx
+++ b/superset-frontend/src/components/Tag/utils.test.tsx
@@ -167,7 +167,7 @@ describe('loadTags', () => {
// Verify all calls include the custom tag filter
calls.forEach(call => {
- const { url } = calls[0];
+ const { url } = call;
const urlObj = new URL(url);
const queryParam = urlObj.searchParams.get('q');
expect(queryParam).not.toBeNull();
diff --git a/superset-frontend/src/core/sqlLab/models.ts
b/superset-frontend/src/core/sqlLab/models.ts
index ce593c582f1..a1bfec12a2c 100644
--- a/superset-frontend/src/core/sqlLab/models.ts
+++ b/superset-frontend/src/core/sqlLab/models.ts
@@ -176,7 +176,7 @@ export class QueryResultContext
requestedLimit?: number;
} = {},
) {
- const { appliedLimit, appliedLimitingFactor, ...opt } = options;
+ const { appliedLimit, ...opt } = options;
super(clientId, tab, runAsync, startDttm, opt);
this.remoteId = remoteId;
this.executedSql = executedSql;
@@ -219,7 +219,7 @@ export class QueryErrorResultContext
queryId?: number;
} = {},
) {
- const { queryId, executedSql, endDttm, ...opt } = options;
+ const { executedSql, endDttm, ...opt } = options;
super(clientId, tab, runAsync, startDttm, opt);
this.executedSql = executedSql ?? null;
this.errorMessage = errorMessage;
diff --git a/superset-frontend/src/dashboard/components/Dashboard.tsx
b/superset-frontend/src/dashboard/components/Dashboard.tsx
index 06f4204a6e9..6b7bb48f0da 100644
--- a/superset-frontend/src/dashboard/components/Dashboard.tsx
+++ b/superset-frontend/src/dashboard/components/Dashboard.tsx
@@ -112,12 +112,8 @@ function Dashboard({
slices,
activeFilters,
chartConfiguration,
- datasources,
ownDataCharts,
layout,
- impressionId,
- timeout = 60,
- userId = '',
children,
}: DashboardProps): JSX.Element {
const context = useContext(PluginContext) as PluginContextType;
diff --git a/superset-frontend/src/dashboard/components/SaveModal.tsx
b/superset-frontend/src/dashboard/components/SaveModal.tsx
index 955c49546eb..fe6a3504d14 100644
--- a/superset-frontend/src/dashboard/components/SaveModal.tsx
+++ b/superset-frontend/src/dashboard/components/SaveModal.tsx
@@ -66,18 +66,18 @@ type SaveModalProps = {
function SaveModal({
saveType: initialSaveType = SAVE_TYPE_OVERWRITE,
- colorNamespace,
- colorScheme,
+ colorNamespace: _colorNamespace,
+ colorScheme: _colorScheme,
shouldPersistRefreshFrequency = false,
dashboardTitle,
onSave,
triggerNode,
canOverwrite,
- addSuccessToast,
+ addSuccessToast: _addSuccessToast,
addDangerToast,
dashboardId,
dashboardInfo,
- expandedSlices,
+ expandedSlices: _expandedSlices,
layout,
customCss,
refreshFrequency,
diff --git
a/superset-frontend/src/dashboard/components/gridComponents/Divider/Divider.test.tsx
b/superset-frontend/src/dashboard/components/gridComponents/Divider/Divider.test.tsx
index 356f8077d3c..cb5c0817c13 100644
---
a/superset-frontend/src/dashboard/components/gridComponents/Divider/Divider.test.tsx
+++
b/superset-frontend/src/dashboard/components/gridComponents/Divider/Divider.test.tsx
@@ -35,7 +35,7 @@ describe('Divider', () => {
index: 0,
editMode: false,
handleComponentDrop: jest.fn(),
- deleteComponent: (id: string, parentId: string) => {},
+ deleteComponent: (_id: string, _parentId: string) => {},
};
const setup = (overrideProps: Partial<DividerProps> = {}) =>
diff --git
a/superset-frontend/src/dashboard/components/gridComponents/TabsRenderer/TabsRenderer.tsx
b/superset-frontend/src/dashboard/components/gridComponents/TabsRenderer/TabsRenderer.tsx
index 6d030b06a56..d9e34e8ec23 100644
---
a/superset-frontend/src/dashboard/components/gridComponents/TabsRenderer/TabsRenderer.tsx
+++
b/superset-frontend/src/dashboard/components/gridComponents/TabsRenderer/TabsRenderer.tsx
@@ -117,7 +117,6 @@ interface DraggableTabNodeProps extends
React.HTMLAttributes<HTMLDivElement> {
}
const DraggableTabNode: React.FC<Readonly<DraggableTabNodeProps>> = ({
- className,
disabled = false,
...props
}) => {
@@ -170,7 +169,6 @@ const TabsRenderer = memo<TabsRendererProps>(
tabBarPaddingLeft = 0,
onTabsReorder,
isEditingTabTitle = false,
- onTabTitleEditingChange,
}) => {
const [activeId, setActiveId] = useState<string | null>(null);
diff --git
a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx
b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx
index a5c86fa2131..e9bcbaa8b91 100644
---
a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx
+++
b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx
@@ -279,7 +279,7 @@ const FilterControls: FC<FilterControlsProps> = ({
);
const customizationRenderer = useCallback(
- (item: ChartCustomization | ChartCustomizationDivider, index: number) => {
+ (item: ChartCustomization | ChartCustomizationDivider, _index: number) => {
if (isChartCustomizationDivider(item)) {
return (
<FilterDivider
diff --git
a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx
b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx
index 47ecde6fd6b..f133db24a25 100644
---
a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx
+++
b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx
@@ -141,8 +141,6 @@ const VerticalFilterBar: FC<VerticalBarProps> = ({
onPendingCustomizationDataMaskChange,
toggleFiltersBar,
width,
- clearAllTriggers,
- onClearAllComplete,
}) => {
const theme = useTheme();
const [isScrolling, setIsScrolling] = useState(false);
diff --git
a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/hooks/useCustomizationOperations.ts
b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/hooks/useCustomizationOperations.ts
index 1390419e7f5..59aa89a4ffe 100644
---
a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/hooks/useCustomizationOperations.ts
+++
b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/hooks/useCustomizationOperations.ts
@@ -105,7 +105,7 @@ export function useCustomizationOperations({
);
const handleRearrangeCustomizations = useCallback(
- (dragIndex: number, targetIndex: number, id: string) => {
+ (dragIndex: number, targetIndex: number, _id: string) => {
const newOrderedIds = [...customizationState.orderedIds];
const [removed] = newOrderedIds.splice(dragIndex, 1);
newOrderedIds.splice(targetIndex, 0, removed);
diff --git
a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/hooks/useFilterOperations.ts
b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/hooks/useFilterOperations.ts
index b57143e8533..cbd217ffde9 100644
---
a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/hooks/useFilterOperations.ts
+++
b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/hooks/useFilterOperations.ts
@@ -125,7 +125,7 @@ export function useFilterOperations({
);
const handleRearrangeFilters = useCallback(
- (dragIndex: number, targetIndex: number, id: string) => {
+ (dragIndex: number, targetIndex: number, _id: string) => {
const newOrderedIds = [...filterState.orderedIds];
const [removed] = newOrderedIds.splice(dragIndex, 1);
newOrderedIds.splice(targetIndex, 0, removed);
diff --git
a/superset-frontend/src/explore/components/DataTablesPane/components/SamplesPane.tsx
b/superset-frontend/src/explore/components/DataTablesPane/components/SamplesPane.tsx
index ae901bc23ac..e743ad6844a 100644
---
a/superset-frontend/src/explore/components/DataTablesPane/components/SamplesPane.tsx
+++
b/superset-frontend/src/explore/components/DataTablesPane/components/SamplesPane.tsx
@@ -60,7 +60,6 @@ export const SamplesPane = ({
queryFormData,
queryForce,
setForceQuery,
- isVisible,
canDownload,
}: SamplesPaneProps) => {
const [filterText, setFilterText] = useState('');
diff --git a/superset-frontend/src/explore/components/ExploreAlert.tsx
b/superset-frontend/src/explore/components/ExploreAlert.tsx
index d4a8a4b4405..456ad512234 100644
--- a/superset-frontend/src/explore/components/ExploreAlert.tsx
+++ b/superset-frontend/src/explore/components/ExploreAlert.tsx
@@ -51,7 +51,7 @@ export const ExploreAlert = forwardRef(
type = 'info',
className = '',
}: ControlPanelAlertProps,
- ref: RefObject<HTMLDivElement>,
+ _ref: RefObject<HTMLDivElement>,
) => (
<ErrorAlert
errorType={title}
diff --git
a/superset-frontend/src/explore/components/ExploreViewContainer/index.tsx
b/superset-frontend/src/explore/components/ExploreViewContainer/index.tsx
index 97234fbb114..faaacd102f5 100644
--- a/superset-frontend/src/explore/components/ExploreViewContainer/index.tsx
+++ b/superset-frontend/src/explore/components/ExploreViewContainer/index.tsx
@@ -893,8 +893,11 @@ function ExploreViewContainer(props:
ExploreViewContainerProps) {
setForceQuery: props.actions.setForceQuery,
postChartFormData: props.actions.postChartFormData,
updateQueryFormData: props.actions.updateQueryFormData,
- setControlValue: (controlName: string, value: any, chartId: number)
=>
- props.actions.setControlValue(controlName, value),
+ setControlValue: (
+ controlName: string,
+ value: any,
+ _chartId: number,
+ ) => props.actions.setControlValue(controlName, value),
}}
can_overwrite={props.can_overwrite}
can_download={props.can_download}
diff --git
a/superset-frontend/src/explore/components/controls/DatasourceControl/index.tsx
b/superset-frontend/src/explore/components/controls/DatasourceControl/index.tsx
index f483d805b55..ef1ef8642b6 100644
---
a/superset-frontend/src/explore/components/controls/DatasourceControl/index.tsx
+++
b/superset-frontend/src/explore/components/controls/DatasourceControl/index.tsx
@@ -221,7 +221,6 @@ const preventRouterLinkWhileMetaClicked = (evt:
React.MouseEvent) => {
export default function DatasourceControl({
actions,
onChange = () => {},
- value = null,
datasource,
form_data,
isEditable = true,
diff --git
a/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopover/index.tsx
b/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopover/index.tsx
index 098899c3897..0750ef6b926 100644
---
a/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopover/index.tsx
+++
b/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopover/index.tsx
@@ -170,7 +170,7 @@ function AdhocFilterEditPopover({
.filter((item: { sliceIndex: number }) => item.sliceIndex !== -1)
.map(
({
- sliceIndex,
+ sliceIndex: _sliceIndex,
...item
}: {
sliceIndex: number;
diff --git
a/superset-frontend/src/explore/components/controls/TextControl/index.tsx
b/superset-frontend/src/explore/components/controls/TextControl/index.tsx
index 710c0632c7a..e69edaeae70 100644
--- a/superset-frontend/src/explore/components/controls/TextControl/index.tsx
+++ b/superset-frontend/src/explore/components/controls/TextControl/index.tsx
@@ -58,11 +58,9 @@ function TextControl<T extends InputValueType =
InputValueType>({
onFocus,
placeholder,
value,
- controlId,
renderTrigger,
validationErrors,
hovered,
- showHeader,
}: TextControlProps<T>) {
const [localValue, setLocalValue] = useState<string>(safeStringify(value));
const prevValueRef = useRef<T | null | undefined>(value);
@@ -126,7 +124,6 @@ function TextControl<T extends InputValueType =
InputValueType>({
displayValue = safeStringify(value);
}
- // Note: controlId and showHeader props are not used by ControlHeader
return (
<div>
<ControlHeader
diff --git a/superset-frontend/src/features/alerts/AlertReportModal.tsx
b/superset-frontend/src/features/alerts/AlertReportModal.tsx
index 422f6306884..f938b2f06f8 100644
--- a/superset-frontend/src/features/alerts/AlertReportModal.tsx
+++ b/superset-frontend/src/features/alerts/AlertReportModal.tsx
@@ -1154,7 +1154,7 @@ const AlertReportModal:
FunctionComponent<AlertReportModalProps> = ({
);
}
})
- .catch(e => {
+ .catch(() => {
addDangerToast(t('There was an error retrieving dashboard tabs.'));
});
}
diff --git
a/superset-frontend/src/features/alerts/components/NotificationMethod.tsx
b/superset-frontend/src/features/alerts/components/NotificationMethod.tsx
index 20d841d7d29..1a5df776491 100644
--- a/superset-frontend/src/features/alerts/components/NotificationMethod.tsx
+++ b/superset-frontend/src/features/alerts/components/NotificationMethod.tsx
@@ -413,7 +413,7 @@ export const NotificationMethod:
FunctionComponent<NotificationMethodProps> = ({
}
}
})
- .catch(e => {
+ .catch(() => {
// Fallback to slack v1 if slack v2 is not compatible
setUseSlackV1(true);
})
diff --git a/superset-frontend/src/features/allEntities/AllEntitiesTable.tsx
b/superset-frontend/src/features/allEntities/AllEntitiesTable.tsx
index 14da5e3c382..776e05cbaac 100644
--- a/superset-frontend/src/features/allEntities/AllEntitiesTable.tsx
+++ b/superset-frontend/src/features/allEntities/AllEntitiesTable.tsx
@@ -61,7 +61,7 @@ interface AllEntitiesTableProps {
}
export default function AllEntitiesTable({
- search = '',
+ search: _search = '',
setShowTagModal,
objects,
canEditTag,
diff --git a/superset-frontend/src/features/annotations/AnnotationModal.tsx
b/superset-frontend/src/features/annotations/AnnotationModal.tsx
index e5e9d0c8121..ba83c8736a2 100644
--- a/superset-frontend/src/features/annotations/AnnotationModal.tsx
+++ b/superset-frontend/src/features/annotations/AnnotationModal.tsx
@@ -208,7 +208,7 @@ const AnnotationModal:
FunctionComponent<AnnotationModalProps> = ({
setCurrentAnnotation(data);
};
- const onDateChange = (dates: any, dateString: Array<string>) => {
+ const onDateChange = (dates: any, _dateString: Array<string>) => {
if (!dates?.[0] || !dates?.[1]) {
const data = {
...currentAnnotation,
diff --git
a/superset-frontend/src/features/databases/DatabaseModal/index.test.tsx
b/superset-frontend/src/features/databases/DatabaseModal/index.test.tsx
index eed4e7d5184..ad2d0968aac 100644
--- a/superset-frontend/src/features/databases/DatabaseModal/index.test.tsx
+++ b/superset-frontend/src/features/databases/DatabaseModal/index.test.tsx
@@ -1941,7 +1941,7 @@ test('validates fix by testing all form field types clear
validation errors', ()
mockClearError();
};
- const handleChangeWithValidation = (actionType: any, payload: any) => {
+ const handleChangeWithValidation = (_actionType: any, _payload: any) => {
handleClearValidationErrors();
};
diff --git a/superset-frontend/src/features/databases/UploadDataModel/index.tsx
b/superset-frontend/src/features/databases/UploadDataModel/index.tsx
index eb28e9877f5..0b58a3cdcea 100644
--- a/superset-frontend/src/features/databases/UploadDataModel/index.tsx
+++ b/superset-frontend/src/features/databases/UploadDataModel/index.tsx
@@ -359,7 +359,7 @@ const UploadDataModal:
FunctionComponent<UploadDataModalProps> = ({
const loadSchemaOptions = useMemo(
() =>
- (input = '', page: number, pageSize: number) => {
+ (_input = '', _page: number, _pageSize: number) => {
if (!currentDatabaseId) {
return Promise.resolve({ data: [], totalCount: 0 });
}
@@ -560,7 +560,7 @@ const UploadDataModal:
FunctionComponent<UploadDataModalProps> = ({
}
}, [show]);
- const validateUpload = (_: any, value: string) => {
+ const validateUpload = (_: any, _value: string) => {
if (fileList.length === 0) {
return Promise.reject(t('Uploading a file is required'));
}
diff --git a/superset-frontend/src/features/roles/RoleListEditModal.test.tsx
b/superset-frontend/src/features/roles/RoleListEditModal.test.tsx
index 9380d4c04a6..57f0769742a 100644
--- a/superset-frontend/src/features/roles/RoleListEditModal.test.tsx
+++ b/superset-frontend/src/features/roles/RoleListEditModal.test.tsx
@@ -329,7 +329,7 @@ describe('RoleListEditModal', () => {
test('fires warning toast when hydration returns zero rows but IDs were
expected', async () => {
const mockGet = SupersetClient.get as jest.Mock;
- mockGet.mockImplementation(({ endpoint }) =>
+ mockGet.mockImplementation(() =>
Promise.resolve({ json: { count: 0, result: [] } }),
);
diff --git a/superset-frontend/src/features/tags/BulkTagModal.tsx
b/superset-frontend/src/features/tags/BulkTagModal.tsx
index 46adac21021..b54f9555c70 100644
--- a/superset-frontend/src/features/tags/BulkTagModal.tsx
+++ b/superset-frontend/src/features/tags/BulkTagModal.tsx
@@ -85,7 +85,7 @@ const BulkTagModal: FC<BulkTagModalProps> = ({
}
addSuccessToast(t('Tagged %s %ss', tagged.length, resourceName));
})
- .catch(err => {
+ .catch(() => {
addDangerToast(t('Failed to tag items'));
});
diff --git a/superset-frontend/src/features/tags/TagModal.tsx
b/superset-frontend/src/features/tags/TagModal.tsx
index 20736d4610c..aea360617de 100644
--- a/superset-frontend/src/features/tags/TagModal.tsx
+++ b/superset-frontend/src/features/tags/TagModal.tsx
@@ -130,7 +130,7 @@ const TagModal: FC<TagModalProps> = ({
setChartsToTag(resourceMap[TaggableResources.Chart]);
setSavedQueriesToTag(resourceMap[TaggableResources.SavedQuery]);
},
- (error: Response) => {
+ (_error: Response) => {
addDangerToast('Error Fetching Tagged Objects');
},
);
diff --git a/superset-frontend/src/features/userInfo/UserInfoModal.tsx
b/superset-frontend/src/features/userInfo/UserInfoModal.tsx
index 1baeab7c68c..4f327f303a0 100644
--- a/superset-frontend/src/features/userInfo/UserInfoModal.tsx
+++ b/superset-frontend/src/features/userInfo/UserInfoModal.tsx
@@ -48,7 +48,7 @@ function UserInfoModal({
: {};
const handleFormSubmit = async (values: FormValues) => {
try {
- const { confirm_password, ...payload } = values;
+ const { confirm_password: _confirm_password, ...payload } = values;
await SupersetClient.put({
endpoint: `/api/v1/me/`,
jsonPayload: { ...payload },
diff --git a/superset-frontend/src/features/users/utils.ts
b/superset-frontend/src/features/users/utils.ts
index 2929ba09622..5450bdca49f 100644
--- a/superset-frontend/src/features/users/utils.ts
+++ b/superset-frontend/src/features/users/utils.ts
@@ -22,7 +22,7 @@ import { SelectOption } from 'src/components/ListView';
import { FormValues } from './types';
export const createUser = async (values: FormValues) => {
- const { confirmPassword, ...payload } = values;
+ const { confirmPassword: _confirmPassword, ...payload } = values;
if (payload.active == null) {
payload.active = false;
}
diff --git a/superset-frontend/src/pages/AllEntities/index.tsx
b/superset-frontend/src/pages/AllEntities/index.tsx
index 941e7665887..d2dfc1f77d1 100644
--- a/superset-frontend/src/pages/AllEntities/index.tsx
+++ b/superset-frontend/src/pages/AllEntities/index.tsx
@@ -155,7 +155,7 @@ function AllEntities() {
setObjects(objects);
setLoading(false);
},
- (error: Response) => {
+ () => {
addDangerToast('Error Fetching Tagged Objects');
setLoading(false);
},
@@ -169,7 +169,7 @@ function AllEntities() {
setTag(tag);
setLoading(false);
},
- (error: Response) => {
+ () => {
addDangerToast(t('Error Fetching Tagged Objects'));
setLoading(false);
},
diff --git
a/superset-frontend/src/pages/ChartList/ChartList.permissions.test.tsx
b/superset-frontend/src/pages/ChartList/ChartList.permissions.test.tsx
index 38db8180d20..4cb84d1b2ca 100644
--- a/superset-frontend/src/pages/ChartList/ChartList.permissions.test.tsx
+++ b/superset-frontend/src/pages/ChartList/ChartList.permissions.test.tsx
@@ -69,9 +69,9 @@ const createMockUser = (overrides = {}) => ({
const createMockStore = (initialState: any = {}) =>
configureStore({
reducer: {
- user: (state = initialState.user || {}, action: any) => state,
- common: (state = initialState.common || {}, action: any) => state,
- charts: (state = initialState.charts || {}, action: any) => state,
+ user: (state = initialState.user || {}, _action: any) => state,
+ common: (state = initialState.common || {}, _action: any) => state,
+ charts: (state = initialState.charts || {}, _action: any) => state,
},
preloadedState: initialState,
middleware: getDefaultMiddleware =>
diff --git
a/superset-frontend/src/pages/DashboardList/DashboardList.permissions.test.tsx
b/superset-frontend/src/pages/DashboardList/DashboardList.permissions.test.tsx
index 68d1229d97b..512722a2f8e 100644
---
a/superset-frontend/src/pages/DashboardList/DashboardList.permissions.test.tsx
+++
b/superset-frontend/src/pages/DashboardList/DashboardList.permissions.test.tsx
@@ -76,9 +76,10 @@ const createMockUser = (overrides = {}) => ({
const createMockStore = (initialState: any = {}) =>
configureStore({
reducer: {
- user: (state = initialState.user || {}, action: any) => state,
- common: (state = initialState.common || {}, action: any) => state,
- dashboards: (state = initialState.dashboards || {}, action: any) =>
state,
+ user: (state = initialState.user || {}, _action: any) => state,
+ common: (state = initialState.common || {}, _action: any) => state,
+ dashboards: (state = initialState.dashboards || {}, _action: any) =>
+ state,
},
preloadedState: initialState,
middleware: getDefaultMiddleware =>
diff --git a/superset-frontend/src/pages/GroupsList/index.tsx
b/superset-frontend/src/pages/GroupsList/index.tsx
index 5f56c46b7e3..2f1e1bc0e83 100644
--- a/superset-frontend/src/pages/GroupsList/index.tsx
+++ b/superset-frontend/src/pages/GroupsList/index.tsx
@@ -146,7 +146,7 @@ function GroupsList({ user }: GroupsListProps) {
.then(() => {
deletedGroupsNames.push(group.name);
})
- .catch(err => {
+ .catch(() => {
addDangerToast(t('Error deleting %s', group.name));
}),
),
diff --git a/superset-frontend/src/pages/UsersList/index.tsx
b/superset-frontend/src/pages/UsersList/index.tsx
index c1bbd9c80b7..b2419641a33 100644
--- a/superset-frontend/src/pages/UsersList/index.tsx
+++ b/superset-frontend/src/pages/UsersList/index.tsx
@@ -168,7 +168,7 @@ function UsersList({ user }: UsersListProps) {
.then(() => {
deletedUserNames.push(user.username);
})
- .catch(err => {
+ .catch(() => {
addDangerToast(t('Error deleting %s', user.username));
}),
),
diff --git a/superset-frontend/src/setup/setupCodeOverrides.ts
b/superset-frontend/src/setup/setupCodeOverrides.ts
index 6c4ea9ab723..e4a269899d8 100644
--- a/superset-frontend/src/setup/setupCodeOverrides.ts
+++ b/superset-frontend/src/setup/setupCodeOverrides.ts
@@ -31,4 +31,6 @@ interface CodeOverrideOptions {
* Hook for individual deployments to add custom overrides
* @param options - Configuration options for the setup process
*/
-export default function setupCodeOverrides(options: CodeOverrideOptions = {})
{}
+export default function setupCodeOverrides(
+ _options: CodeOverrideOptions = {},
+) {}
diff --git a/superset-frontend/src/theme/ThemeController.ts
b/superset-frontend/src/theme/ThemeController.ts
index cfc79484fbd..a51157e92f5 100644
--- a/superset-frontend/src/theme/ThemeController.ts
+++ b/superset-frontend/src/theme/ThemeController.ts
@@ -358,7 +358,7 @@ export class ThemeController {
* @throws {Error} If the user does not have permission to update the theme
mode
*/
public setThemeMode(mode: ThemeMode): void {
- this.validateModeUpdatePermission(mode);
+ this.validateModeUpdatePermission();
if (
this.currentMode === mode &&
@@ -543,7 +543,7 @@ export class ThemeController {
let newMode: ThemeMode;
try {
- this.validateModeUpdatePermission(this.currentMode);
+ this.validateModeUpdatePermission();
const hasRequiredTheme = this.isValidThemeMode(this.currentMode);
newMode = hasRequiredTheme
? this.currentMode
@@ -863,10 +863,9 @@ export class ThemeController {
/**
* Validates permission to update mode.
- * @param newMode - The new mode to validate
* @throws {Error} If the user does not have permission to update the theme
mode
*/
- private validateModeUpdatePermission(newMode: ThemeMode): void {
+ private validateModeUpdatePermission(): void {
// Check if user can set a new theme mode (dark theme must exist)
if (!this.canSetMode())
throw new Error(
