This is an automated email from the ASF dual-hosted git repository. hainenber pushed a commit to branch fix/resolve-shellcheck-flagged-errors in repository https://gitbox.apache.org/repos/asf/superset.git
commit 801baf0a0abfcbac7141ca1bff422653411433d4 Author: hainenber <[email protected]> AuthorDate: Sun Jul 26 11:08:58 2026 +0700 chore(ci): resolve shellcheck-flagged errors Signed-off-by: hainenber <[email protected]> --- RELEASING/validate_this_release.sh | 4 ++-- docker/apt-install.sh | 2 +- docker/tag_latest_release.sh | 4 ++-- scripts/check_license.sh | 4 ++-- scripts/tag_latest_release.sh | 4 ++-- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/RELEASING/validate_this_release.sh b/RELEASING/validate_this_release.sh index 4942803702c..53673ffc287 100755 --- a/RELEASING/validate_this_release.sh +++ b/RELEASING/validate_this_release.sh @@ -1,3 +1,5 @@ +#!/usr/bin/env bash + # Licensed to the Apache Software Foundation (ASF) under one # or more contributor license agreements. See the NOTICE file # distributed with this work for additional information @@ -15,8 +17,6 @@ # specific language governing permissions and limitations # under the License. -#!/bin/bash - # Function to determine Python command get_python_command() { if command -v python3 &>/dev/null; then diff --git a/docker/apt-install.sh b/docker/apt-install.sh index 1c36353199e..c1423364c38 100755 --- a/docker/apt-install.sh +++ b/docker/apt-install.sh @@ -38,7 +38,7 @@ RESET='\033[0m' echo -e "${GREEN}Updating package lists...${RESET}" apt-get update -qq -echo -e "${GREEN}Installing packages: $@${RESET}" +echo -e "${GREEN}Installing packages: $*${RESET}" apt-get install -yqq --no-install-recommends "$@" echo -e "${GREEN}Autoremoving unnecessary packages...${RESET}" diff --git a/docker/tag_latest_release.sh b/docker/tag_latest_release.sh index b57c67e25f6..362ce4f47ee 100755 --- a/docker/tag_latest_release.sh +++ b/docker/tag_latest_release.sh @@ -163,10 +163,10 @@ do # Iterate through the components of the version strings for (( j=0; j<${#THIS_TAG_NAME_ARRAY[@]}; j++ )); do echo "Comparing ${THIS_TAG_NAME_ARRAY[$j]} to ${LATEST_RELEASE_TAG_ARRAY[$j]}" - if [[ $((THIS_TAG_NAME_ARRAY[$j])) > $((LATEST_RELEASE_TAG_ARRAY[$j])) ]]; then + if [[ $((THIS_TAG_NAME_ARRAY[$j])) -gt $((LATEST_RELEASE_TAG_ARRAY[$j])) ]]; then compare_result="greater" break - elif [[ $((THIS_TAG_NAME_ARRAY[$j])) < $((LATEST_RELEASE_TAG_ARRAY[$j])) ]]; then + elif [[ $((THIS_TAG_NAME_ARRAY[$j])) -lt $((LATEST_RELEASE_TAG_ARRAY[$j])) ]]; then compare_result="lesser" break fi diff --git a/scripts/check_license.sh b/scripts/check_license.sh index 28f2ddec319..9a00b07dec4 100755 --- a/scripts/check_license.sh +++ b/scripts/check_license.sh @@ -35,7 +35,7 @@ acquire_rat_jar () { wget --quiet ${URL} -O "$JAR_DL" && mv "$JAR_DL" "$JAR" else printf "You do not have curl or wget installed, please install rat manually.\n" - exit -1 + exit 255 fi fi @@ -44,7 +44,7 @@ acquire_rat_jar () { # We failed to download rm "$JAR" printf "Our attempt to download rat locally to ${JAR} failed. Please install rat manually.\n" - exit -1 + exit 255 fi printf "Done downloading.\n" } diff --git a/scripts/tag_latest_release.sh b/scripts/tag_latest_release.sh index b57c67e25f6..362ce4f47ee 100755 --- a/scripts/tag_latest_release.sh +++ b/scripts/tag_latest_release.sh @@ -163,10 +163,10 @@ do # Iterate through the components of the version strings for (( j=0; j<${#THIS_TAG_NAME_ARRAY[@]}; j++ )); do echo "Comparing ${THIS_TAG_NAME_ARRAY[$j]} to ${LATEST_RELEASE_TAG_ARRAY[$j]}" - if [[ $((THIS_TAG_NAME_ARRAY[$j])) > $((LATEST_RELEASE_TAG_ARRAY[$j])) ]]; then + if [[ $((THIS_TAG_NAME_ARRAY[$j])) -gt $((LATEST_RELEASE_TAG_ARRAY[$j])) ]]; then compare_result="greater" break - elif [[ $((THIS_TAG_NAME_ARRAY[$j])) < $((LATEST_RELEASE_TAG_ARRAY[$j])) ]]; then + elif [[ $((THIS_TAG_NAME_ARRAY[$j])) -lt $((LATEST_RELEASE_TAG_ARRAY[$j])) ]]; then compare_result="lesser" break fi
