This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a commit to branch fix/docs-netlify-node-version
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/fix/docs-netlify-node-version
by this push:
new ed90e18e71a fix(docs): unbreak Netlify docs preview build
ed90e18e71a is described below
commit ed90e18e71ac478cca44b9f3ebf4aa08e1a0ce19
Author: Claude Code <[email protected]>
AuthorDate: Tue Sep 8 08:08:10 2026 -0700
fix(docs): unbreak Netlify docs preview build
The docs Netlify build has been failing on every PR (unrelated to their
content) for two independent reasons:
1. docs/netlify.toml hardcoded NODE_VERSION = "20", which drifted out of
sync after the repo moved to Node 24 (#40835, #41500). docs/.nvmrc is
already a symlink to superset-frontend/.nvmrc, the repo's single source
of truth for Node version, so drop the hardcoded override and let
Netlify auto-detect from that file instead of duplicating it.
2. @ant-design/icons was bumped to 6.3.3 (#43951), which imports icon
assets (e.g. MetaFilled, NetflixFilled) that only exist starting in
@ant-design/icons-svg 4.6.0. Its own declared dependency range
(^4.5.0) still allowed yarn to resolve the older 4.5.0, so the webpack
build failed with "Module not found". Pin @ant-design/icons-svg to
^4.6.0 via the existing resolutions block.
Verified locally under Node 24 (matching .nvmrc): yarn install and
yarn build both succeed and produce a populated docs/build/ directory.
Co-Authored-By: Claude Sonnet 5 <[email protected]>
---
docs/netlify.toml | 7 +++++--
docs/package.json | 3 ++-
docs/yarn.lock | 8 ++++----
3 files changed, 11 insertions(+), 7 deletions(-)
diff --git a/docs/netlify.toml b/docs/netlify.toml
index 5c3e2a49c1b..fcde3527417 100644
--- a/docs/netlify.toml
+++ b/docs/netlify.toml
@@ -43,8 +43,11 @@ publish = "build"
ignore = 'if [ -n "$CACHED_COMMIT_REF" ]; then git diff --quiet
"$CACHED_COMMIT_REF" HEAD -- . ../README.md; else git fetch --no-tags origin
master >/dev/null 2>&1 || true; i=0; while [ "$i" -lt 10 ] && ! git merge-base
origin/master HEAD >/dev/null 2>&1; do git fetch --deepen=200 origin master
>/dev/null 2>&1 || break; i=$((i+1)); done; BASE="$(git merge-base
origin/master HEAD 2>/dev/null || true)"; if [ -z "$BASE" ]; then exit 1; fi;
git diff --quiet "$BASE" HEAD -- . ../README.md; fi'
[build.environment]
-# Node version matching docs/.nvmrc
-NODE_VERSION = "20"
+# Node version is intentionally not pinned here: Netlify auto-detects it
+# from docs/.nvmrc, which is a symlink to the repo's single source of truth
+# at superset-frontend/.nvmrc. Duplicating the version here previously let
+# it drift out of sync (stuck on Node 20 after the repo moved to Node 24),
+# breaking installs once a dependency required a newer Node engine.
# Yarn version
YARN_VERSION = "1.22.22"
# Increase heap size for webpack bundling of Superset UI components
diff --git a/docs/package.json b/docs/package.json
index 52a02807c98..b0bb40f620e 100644
--- a/docs/package.json
+++ b/docs/package.json
@@ -116,7 +116,8 @@
"serialize-javascript": "7.0.5",
"d3-color": "3.1.0",
"ws": "^8.21.0",
- "docusaurus-plugin-openapi-docs/**/js-yaml": "^4.3.0"
+ "docusaurus-plugin-openapi-docs/**/js-yaml": "^4.3.0",
+ "@ant-design/icons-svg": "^4.6.0"
},
"packageManager":
"[email protected]+sha1.ac34549e6aa8e7ead463a7407e1c7390f61a6610"
}
diff --git a/docs/yarn.lock b/docs/yarn.lock
index 837b24804c1..1e7cbc4b6b1 100644
--- a/docs/yarn.lock
+++ b/docs/yarn.lock
@@ -222,10 +222,10 @@
resolved
"https://registry.yarnpkg.com/@ant-design/fast-color/-/fast-color-3.0.1.tgz#fee56b95427c0b55b216c93d9a7f3473f31615b5";
integrity
sha512-esKJegpW4nckh0o6kV3Tkb7NPIZYbPnnFxmQDUmL08ukXZAvV85TZBr70eGuke/CIArLaP6aw8lt9KILjnWuOw==
-"@ant-design/icons-svg@^4.5.0":
- version "4.5.0"
- resolved
"https://registry.yarnpkg.com/@ant-design/icons-svg/-/icons-svg-4.5.0.tgz#7b1c567e489840d747f211d3688949bcba363ad2";
- integrity
sha512-1BTUFyKPTBZ53MuTP8s0k5SFEXL7o3VHEOwLgzaoWKwnBeqIcqUtVshc4SKzhI6uACfqhJqBwBUE9FsWR3uULA==
+"@ant-design/icons-svg@^4.5.0", "@ant-design/icons-svg@^4.6.0":
+ version "4.6.0"
+ resolved
"https://registry.yarnpkg.com/@ant-design/icons-svg/-/icons-svg-4.6.0.tgz#5f7ebfe2a6b7c871920f73db095bd4ab50d7764d";
+ integrity
sha512-PRomU725ABMf/lnQp5HiB7my1kjEbFY0D10N4lXYxK6TIB1gKjIVD5MRThpDaezLgw1D774J8eOeeDB0M6wHrQ==
"@ant-design/icons@^6.3.2", "@ant-design/icons@^6.3.3":
version "6.3.3"
