This is an automated email from the ASF dual-hosted git repository. hainenber pushed a commit to branch feat/generate-playwright-runnable-tests-from-storybook-stories in repository https://gitbox.apache.org/repos/asf/superset.git
commit b654f880b420c845b5f1eff0ccc631fcd27b8679 Author: hainenber <[email protected]> AuthorDate: Sun Oct 4 16:06:08 2026 +0700 feat(ci): use `test-storybook` npm command solely for Storybook component testing Signed-off-by: hainenber <[email protected]> --- .github/workflows/superset-frontend.yml | 2 +- superset-frontend/package.json | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/superset-frontend.yml b/.github/workflows/superset-frontend.yml index 6518621206a..a44d0c8254f 100644 --- a/.github/workflows/superset-frontend.yml +++ b/.github/workflows/superset-frontend.yml @@ -201,7 +201,7 @@ jobs: - name: Build Storybook and Run Tests run: | docker run --rm $TAG bash -c \ - "npm run build-storybook && npx playwright install-deps && npx playwright install chromium && npm run test-storybook:ci" + "npx playwright install-deps && npx playwright install chromium && npm run test-storybook" actions-timeline: needs: [report-coverage, lint-frontend, validate-frontend, test-storybook] diff --git a/superset-frontend/package.json b/superset-frontend/package.json index 82c25e9585f..b11f00223ea 100644 --- a/superset-frontend/package.json +++ b/superset-frontend/package.json @@ -81,8 +81,7 @@ "prod": "npm run build", "prune": "rm -rf ./{packages,plugins}/*/{node_modules,lib,esm,tsconfig.tsbuildinfo,package-lock.json} ./.temp_cache ./coverage ./storybook-static", "storybook": "cross-env NODE_ENV=development BABEL_ENV=development storybook dev -p 6006", - "test-storybook": "test-storybook", - "test-storybook:ci": "concurrently --kill-others --success first --names \"SB,TEST\" --prefix-colors \"magenta,blue\" \"python3 -m http.server 6006 --directory storybook-static\" \"npx wait-on tcp:127.0.0.1:6006 && npm run test-storybook -- --maxWorkers=2 --testTimeout 60000\"", + "test-storybook": "npx playwright test --config .storybook/playwright.storybook-ci.config.ts", "tdd": "cross-env NODE_ENV=test NODE_OPTIONS=\"--max-old-space-size=8192\" jest --watch", "test": "cross-env NODE_ENV=test NODE_OPTIONS=\"--max-old-space-size=8192\" jest --max-workers=80% --silent", "test-loud": "cross-env NODE_ENV=test NODE_OPTIONS=\"--max-old-space-size=8192\" jest --max-workers=80%",
