This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 2385cd4  [explore] make edit datasource a basic link (#3244)
2385cd4 is described below

commit 2385cd445bf1eeffa9d1526640590f31317c3db4
Author: Maxime Beauchemin <maximebeauche...@gmail.com>
AuthorDate: Tue Aug 8 12:29:24 2017 -0700

    [explore] make edit datasource a basic link (#3244)
---
 .../components/controls/DatasourceControl.jsx      | 23 ++++++++++++----------
 1 file changed, 13 insertions(+), 10 deletions(-)

diff --git 
a/superset/assets/javascripts/explore/components/controls/DatasourceControl.jsx 
b/superset/assets/javascripts/explore/components/controls/DatasourceControl.jsx
index 20e12a5..b00fe3f 100644
--- 
a/superset/assets/javascripts/explore/components/controls/DatasourceControl.jsx
+++ 
b/superset/assets/javascripts/explore/components/controls/DatasourceControl.jsx
@@ -5,7 +5,6 @@ import { Table } from 'reactable';
 import { Label, FormControl, Modal, OverlayTrigger, Tooltip } from 
'react-bootstrap';
 
 import ControlHeader from '../ControlHeader';
-import InfoTooltipWithTrigger from 
'../../../components/InfoTooltipWithTrigger';
 
 const propTypes = {
   description: PropTypes.string,
@@ -95,18 +94,22 @@ export default class DatasourceControl extends 
React.PureComponent {
             <Tooltip id={'error-tooltip'}>Click to point to another 
datasource</Tooltip>
           }
         >
-          <Label onClick={this.toggleModal} style={{ cursor: 'pointer' }} 
className="m-r-3">
+          <Label onClick={this.toggleModal} style={{ cursor: 'pointer' }} 
className="m-r-5">
             {this.props.datasource.name}
           </Label>
         </OverlayTrigger>
-        <InfoTooltipWithTrigger
-          tooltip="edit the datasource's configuration"
-          icon="edit"
-          label="edit datasource"
-          onClick={() => {
-            window.location = this.props.datasource.edit_url;
-          }}
-        />
+        <OverlayTrigger
+          placement="right"
+          overlay={
+            <Tooltip id={'edit-datasource-tooltip'}>
+              Edit the datasource's configuration
+            </Tooltip>
+          }
+        >
+          <a href={this.props.datasource.edit_url}>
+            <i className="fa fa-edit" />
+          </a>
+        </OverlayTrigger>
         <Modal
           show={this.state.showModal}
           onHide={this.toggleModal}

-- 
To stop receiving notification emails like this one, please contact
['"comm...@superset.apache.org" <comm...@superset.apache.org>'].

Reply via email to