This is an automated email from the ASF dual-hosted git repository.
maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new 08e40e2 add placeholder to Select components (#3274)
08e40e2 is described below
commit 08e40e2d78bde55a185480130e0ced9f979453aa
Author: Rogan <quang...@gmail.com>
AuthorDate: Fri Aug 11 11:51:36 2017 +0800
add placeholder to Select components (#3274)
---
superset/assets/javascripts/explore/components/SaveModal.jsx | 1 +
superset/assets/visualizations/filter_box.jsx | 1 +
2 files changed, 2 insertions(+)
diff --git a/superset/assets/javascripts/explore/components/SaveModal.jsx
b/superset/assets/javascripts/explore/components/SaveModal.jsx
index beb07b2..b3a69a3 100644
--- a/superset/assets/javascripts/explore/components/SaveModal.jsx
+++ b/superset/assets/javascripts/explore/components/SaveModal.jsx
@@ -188,6 +188,7 @@ class SaveModal extends React.Component {
onChange={this.onChange.bind(this, 'saveToDashboardId')}
autoSize={false}
value={this.state.saveToDashboardId}
+ placeholder="Select Dashboard"
/>
<Radio
diff --git a/superset/assets/visualizations/filter_box.jsx
b/superset/assets/visualizations/filter_box.jsx
index 7e02dd5..5325a5d 100644
--- a/superset/assets/visualizations/filter_box.jsx
+++ b/superset/assets/visualizations/filter_box.jsx
@@ -66,6 +66,7 @@ class FilterBox extends React.Component {
<div className="m-b-5" key={field}>
{field.replace('__', '')}
<Select.Creatable
+ placeholder="Select"
options={options}
value={this.state.selectedValues[field]}
onChange={this.changeFilter.bind(this, field)}
--
To stop receiving notification emails like this one, please contact
['"comm...@superset.apache.org" <comm...@superset.apache.org>'].
