This is an automated email from the ASF dual-hosted git repository.
graceguo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new 12fb7c1 When checking if you should renderTriggered make sure key
exists in controls (#3912)
12fb7c1 is described below
commit 12fb7c1a627966a1350fca61a09dc9864eb972aa
Author: michellethomas <[email protected]>
AuthorDate: Tue Nov 21 10:22:55 2017 -0800
When checking if you should renderTriggered make sure key exists in
controls (#3912)
---
superset/assets/javascripts/explore/components/ExploreViewContainer.jsx | 1 +
1 file changed, 1 insertion(+)
diff --git
a/superset/assets/javascripts/explore/components/ExploreViewContainer.jsx
b/superset/assets/javascripts/explore/components/ExploreViewContainer.jsx
index 43f6c01..835cc1a 100644
--- a/superset/assets/javascripts/explore/components/ExploreViewContainer.jsx
+++ b/superset/assets/javascripts/explore/components/ExploreViewContainer.jsx
@@ -53,6 +53,7 @@ class ExploreViewContainer extends React.Component {
}
// if any control value changed and it's an instant control
if (Object.keys(np.controls).some(key => (np.controls[key].renderTrigger &&
+ typeof this.props.controls[key] !== 'undefined' &&
!areObjectsEqual(np.controls[key].value,
this.props.controls[key].value)))) {
this.props.actions.renderTriggered(new Date().getTime(),
this.props.chart.chartKey);
}
--
To stop receiving notification emails like this one, please contact
['"[email protected]" <[email protected]>'].
