This is an automated email from the ASF dual-hosted git repository.
graceguo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new 7cd9b85 [bugfix] iframe and markup are broken (#4082)
7cd9b85 is described below
commit 7cd9b85831a82459c221697b58e52dec69b35598
Author: Maxime Beauchemin <[email protected]>
AuthorDate: Mon Dec 18 14:42:18 2017 -0800
[bugfix] iframe and markup are broken (#4082)
fixes https://github.com/apache/incubator-superset/issues/4080
---
superset/viz.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/superset/viz.py b/superset/viz.py
index 9b913e4..85bc854 100644
--- a/superset/viz.py
+++ b/superset/viz.py
@@ -262,7 +262,7 @@ class BaseViz(object):
df = self.get_df()
if not self.error_message:
data = self.get_data(df)
- rowcount = len(df.index)
+ rowcount = len(df.index) if df is not None else 0
except Exception as e:
logging.exception(e)
if not self.error_message:
@@ -523,7 +523,7 @@ class MarkupViz(BaseViz):
is_timeseries = False
def get_df(self):
- return True
+ return None
def get_data(self, df):
markup_type = self.form_data.get('markup_type')
--
To stop receiving notification emails like this one, please contact
['"[email protected]" <[email protected]>'].
