This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 627bdb2  [dashboard] open in edit mode when adding a chart (#4772)
627bdb2 is described below

commit 627bdb2eb3de5185bbad369b25f392323eb66332
Author: Maxime Beauchemin <maximebeauche...@gmail.com>
AuthorDate: Sat Apr 7 12:55:05 2018 -0700

    [dashboard] open in edit mode when adding a chart (#4772)
    
    * [dashboard] open in edit mode when adding a chart
    
    * Move dashboard unit tests to their own file
    
    * fix tests
    
    * Better URL management
---
 run_specific_test.sh                               |   2 +-
 superset/assets/javascripts/dashboard/reducers.js  |   4 +-
 .../javascripts/explore/components/SaveModal.jsx   |   3 +-
 superset/assets/utils/common.js                    |   8 +
 superset/views/core.py                             |   1 +
 tests/core_tests.py                                | 252 -----------------
 tests/dashboard_tests.py                           | 300 +++++++++++++++++++++
 tests/druid_tests.py                               |   4 +-
 8 files changed, 316 insertions(+), 258 deletions(-)

diff --git a/run_specific_test.sh b/run_specific_test.sh
index f267e08..0be8e55 100755
--- a/run_specific_test.sh
+++ b/run_specific_test.sh
@@ -7,4 +7,4 @@ set -e
 superset/bin/superset version -v
 export SOLO_TEST=1
 # e.g. tests.core_tests:CoreTests.test_templated_sql_json
-nosetests $1
+nosetests $1 $2 $3
diff --git a/superset/assets/javascripts/dashboard/reducers.js 
b/superset/assets/javascripts/dashboard/reducers.js
index 1cc3e76..074c445 100644
--- a/superset/assets/javascripts/dashboard/reducers.js
+++ b/superset/assets/javascripts/dashboard/reducers.js
@@ -11,7 +11,7 @@ import { applyDefaultFormData } from 
'../explore/stores/store';
 import { getColorFromScheme } from '../modules/colors';
 
 export function getInitialState(bootstrapData) {
-  const { user_id, datasources, common } = bootstrapData;
+  const { user_id, datasources, common, editMode } = bootstrapData;
   delete common.locale;
   delete common.language_pack;
 
@@ -89,7 +89,7 @@ export function getInitialState(bootstrapData) {
 
   return {
     charts: initCharts,
-    dashboard: { filters, dashboard, userId: user_id, datasources, common, 
editMode: false },
+    dashboard: { filters, dashboard, userId: user_id, datasources, common, 
editMode },
   };
 }
 
diff --git a/superset/assets/javascripts/explore/components/SaveModal.jsx 
b/superset/assets/javascripts/explore/components/SaveModal.jsx
index 5489fba..4aa7670 100644
--- a/superset/assets/javascripts/explore/components/SaveModal.jsx
+++ b/superset/assets/javascripts/explore/components/SaveModal.jsx
@@ -6,6 +6,7 @@ import { connect } from 'react-redux';
 import { Modal, Alert, Button, Radio } from 'react-bootstrap';
 import Select from 'react-select';
 import { t } from '../../locales';
+import { supersetURL } from '../../../utils/common';
 
 const propTypes = {
   can_overwrite: PropTypes.bool,
@@ -107,7 +108,7 @@ class SaveModal extends React.Component {
       .then((data) => {
         // Go to new slice url or dashboard url
         if (gotodash) {
-          window.location = data.dashboard;
+          window.location = supersetURL(data.dashboard, { edit: 'true' });
         } else {
           window.location = data.slice.slice_url;
         }
diff --git a/superset/assets/utils/common.js b/superset/assets/utils/common.js
index 2e143a1..c7be5dd 100644
--- a/superset/assets/utils/common.js
+++ b/superset/assets/utils/common.js
@@ -86,3 +86,11 @@ export function getShortUrl(longUrl, callback) {
     },
   });
 }
+
+export function supersetURL(rootUrl, getParams = {}) {
+  const url = new URL(rootUrl, window.location.origin);
+  for (const k in getParams) {
+    url.searchParams.set(k, getParams[k]);
+  }
+  return url.href;
+}
diff --git a/superset/views/core.py b/superset/views/core.py
index c2099e3..7eb6d3a 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -2074,6 +2074,7 @@ class Superset(BaseSupersetView):
             'dashboard_data': dashboard_data,
             'datasources': {ds.uid: ds.data for ds in datasources},
             'common': self.common_bootsrap_payload(),
+            'editMode': request.args.get('edit') == 'true',
         }
 
         if request.args.get('json') == 'true':
diff --git a/tests/core_tests.py b/tests/core_tests.py
index 6f82af8..4b0fc46 100644
--- a/tests/core_tests.py
+++ b/tests/core_tests.py
@@ -16,7 +16,6 @@ import random
 import string
 import unittest
 
-from flask import escape
 import pandas as pd
 import psycopg2
 from six import text_type
@@ -293,14 +292,6 @@ class CoreTests(SupersetTestCase):
             print('[{name}]/[{method}]: {url}'.format(**locals()))
             response = self.client.get(url)
 
-    def test_dashboard(self):
-        self.login(username='admin')
-        urls = {}
-        for dash in db.session.query(models.Dashboard).all():
-            urls[dash.dashboard_title] = dash.url
-        for title, url in urls.items():
-            assert escape(title) in self.client.get(url).data.decode('utf-8')
-
     def test_doctests(self):
         modules = [utils, models, sql_lab]
         for mod in modules:
@@ -421,167 +412,6 @@ class CoreTests(SupersetTestCase):
         except Exception:
             self.assertRaises(TypeError)
 
-    def test_save_dash(self, username='admin'):
-        self.login(username=username)
-        dash = db.session.query(models.Dashboard).filter_by(
-            slug='births').first()
-        positions = []
-        for i, slc in enumerate(dash.slices):
-            d = {
-                'col': 0,
-                'row': i * 4,
-                'size_x': 4,
-                'size_y': 4,
-                'slice_id': '{}'.format(slc.id)}
-            positions.append(d)
-        data = {
-            'css': '',
-            'expanded_slices': {},
-            'positions': positions,
-            'dashboard_title': dash.dashboard_title,
-        }
-        url = '/superset/save_dash/{}/'.format(dash.id)
-        resp = self.get_resp(url, data=dict(data=json.dumps(data)))
-        self.assertIn('SUCCESS', resp)
-
-    def test_save_dash_with_filter(self, username='admin'):
-        self.login(username=username)
-        dash = db.session.query(models.Dashboard).filter_by(
-            slug='world_health').first()
-        positions = []
-        for i, slc in enumerate(dash.slices):
-            d = {
-                'col': 0,
-                'row': i * 4,
-                'size_x': 4,
-                'size_y': 4,
-                'slice_id': '{}'.format(slc.id)}
-            positions.append(d)
-
-        filters = {str(dash.slices[0].id): {'region': ['North America']}}
-        default_filters = json.dumps(filters)
-        data = {
-            'css': '',
-            'expanded_slices': {},
-            'positions': positions,
-            'dashboard_title': dash.dashboard_title,
-            'default_filters': default_filters,
-        }
-
-        url = '/superset/save_dash/{}/'.format(dash.id)
-        resp = self.get_resp(url, data=dict(data=json.dumps(data)))
-        self.assertIn('SUCCESS', resp)
-
-        updatedDash = db.session.query(models.Dashboard).filter_by(
-            slug='world_health').first()
-        new_url = updatedDash.url
-        self.assertIn('region', new_url)
-
-        resp = self.get_resp(new_url)
-        self.assertIn('North America', resp)
-
-    def test_save_dash_with_dashboard_title(self, username='admin'):
-        self.login(username=username)
-        dash = (
-            db.session.query(models.Dashboard)
-            .filter_by(slug='births')
-            .first()
-        )
-        origin_title = dash.dashboard_title
-        positions = []
-        for i, slc in enumerate(dash.slices):
-            d = {
-                'col': 0,
-                'row': i * 4,
-                'size_x': 4,
-                'size_y': 4,
-                'slice_id': '{}'.format(slc.id)}
-            positions.append(d)
-        data = {
-            'css': '',
-            'expanded_slices': {},
-            'positions': positions,
-            'dashboard_title': 'new title',
-        }
-        url = '/superset/save_dash/{}/'.format(dash.id)
-        self.get_resp(url, data=dict(data=json.dumps(data)))
-        updatedDash = (
-            db.session.query(models.Dashboard)
-            .filter_by(slug='births')
-            .first()
-        )
-        self.assertEqual(updatedDash.dashboard_title, 'new title')
-        # # bring back dashboard original title
-        data['dashboard_title'] = origin_title
-        self.get_resp(url, data=dict(data=json.dumps(data)))
-
-    def test_copy_dash(self, username='admin'):
-        self.login(username=username)
-        dash = db.session.query(models.Dashboard).filter_by(
-            slug='births').first()
-        positions = []
-        for i, slc in enumerate(dash.slices):
-            d = {
-                'col': 0,
-                'row': i * 4,
-                'size_x': 4,
-                'size_y': 4,
-                'slice_id': '{}'.format(slc.id)}
-            positions.append(d)
-        data = {
-            'css': '',
-            'duplicate_slices': False,
-            'expanded_slices': {},
-            'positions': positions,
-            'dashboard_title': 'Copy Of Births',
-        }
-
-        # Save changes to Births dashboard and retrieve updated dash
-        dash_id = dash.id
-        url = '/superset/save_dash/{}/'.format(dash_id)
-        self.client.post(url, data=dict(data=json.dumps(data)))
-        dash = db.session.query(models.Dashboard).filter_by(
-            id=dash_id).first()
-        orig_json_data = dash.data
-
-        # Verify that copy matches original
-        url = '/superset/copy_dash/{}/'.format(dash_id)
-        resp = self.get_json_resp(url, data=dict(data=json.dumps(data)))
-        self.assertEqual(resp['dashboard_title'], 'Copy Of Births')
-        self.assertEqual(resp['position_json'], 
orig_json_data['position_json'])
-        self.assertEqual(resp['metadata'], orig_json_data['metadata'])
-        self.assertEqual(resp['slices'], orig_json_data['slices'])
-
-    def test_add_slices(self, username='admin'):
-        self.login(username=username)
-        dash = db.session.query(models.Dashboard).filter_by(
-            slug='births').first()
-        new_slice = db.session.query(models.Slice).filter_by(
-            slice_name='Mapbox Long/Lat').first()
-        existing_slice = db.session.query(models.Slice).filter_by(
-            slice_name='Name Cloud').first()
-        data = {
-            'slice_ids': [new_slice.data['slice_id'],
-                          existing_slice.data['slice_id']],
-        }
-        url = '/superset/add_slices/{}/'.format(dash.id)
-        resp = self.client.post(url, data=dict(data=json.dumps(data)))
-        assert 'SLICES ADDED' in resp.data.decode('utf-8')
-
-        dash = db.session.query(models.Dashboard).filter_by(
-            slug='births').first()
-        new_slice = db.session.query(models.Slice).filter_by(
-            slice_name='Mapbox Long/Lat').first()
-        assert new_slice in dash.slices
-        assert len(set(dash.slices)) == len(dash.slices)
-
-        # cleaning up
-        dash = db.session.query(models.Dashboard).filter_by(
-            slug='births').first()
-        dash.slices = [
-            o for o in dash.slices if o.slice_name != 'Mapbox Long/Lat']
-        db.session.commit()
-
     def test_gamma(self):
         self.login(username='gamma')
         assert 'List Charts' in self.get_resp('/slicemodelview/list/')
@@ -605,88 +435,6 @@ class CoreTests(SupersetTestCase):
         self.assertEqual(list(expected_data), list(data))
         self.logout()
 
-    def test_public_user_dashboard_access(self):
-        table = (
-            db.session
-            .query(SqlaTable)
-            .filter_by(table_name='birth_names')
-            .one()
-        )
-        # Try access before adding appropriate permissions.
-        self.revoke_public_access_to_table(table)
-        self.logout()
-
-        resp = self.get_resp('/slicemodelview/list/')
-        self.assertNotIn('birth_names</a>', resp)
-
-        resp = self.get_resp('/dashboardmodelview/list/')
-        self.assertNotIn('/superset/dashboard/births/', resp)
-
-        self.grant_public_access_to_table(table)
-
-        # Try access after adding appropriate permissions.
-        self.assertIn('birth_names', self.get_resp('/slicemodelview/list/'))
-
-        resp = self.get_resp('/dashboardmodelview/list/')
-        self.assertIn('/superset/dashboard/births/', resp)
-
-        self.assertIn('Births', self.get_resp('/superset/dashboard/births/'))
-
-        # Confirm that public doesn't have access to other datasets.
-        resp = self.get_resp('/slicemodelview/list/')
-        self.assertNotIn('wb_health_population</a>', resp)
-
-        resp = self.get_resp('/dashboardmodelview/list/')
-        self.assertNotIn('/superset/dashboard/world_health/', resp)
-
-    def test_dashboard_with_created_by_can_be_accessed_by_public_users(self):
-        self.logout()
-        table = (
-            db.session
-            .query(SqlaTable)
-            .filter_by(table_name='birth_names')
-            .one()
-        )
-        self.grant_public_access_to_table(table)
-
-        dash = db.session.query(models.Dashboard).filter_by(
-            slug='births').first()
-        dash.owners = [security_manager.find_user('admin')]
-        dash.created_by = security_manager.find_user('admin')
-        db.session.merge(dash)
-        db.session.commit()
-
-        assert 'Births' in self.get_resp('/superset/dashboard/births/')
-
-    def test_only_owners_can_save(self):
-        dash = (
-            db.session
-            .query(models.Dashboard)
-            .filter_by(slug='births')
-            .first()
-        )
-        dash.owners = []
-        db.session.merge(dash)
-        db.session.commit()
-        self.test_save_dash('admin')
-
-        self.logout()
-        self.assertRaises(
-            Exception, self.test_save_dash, 'alpha')
-
-        alpha = security_manager.find_user('alpha')
-
-        dash = (
-            db.session
-            .query(models.Dashboard)
-            .filter_by(slug='births')
-            .first()
-        )
-        dash.owners = [alpha]
-        db.session.merge(dash)
-        db.session.commit()
-        self.test_save_dash('alpha')
-
     def test_extra_table_metadata(self):
         self.login('admin')
         dbid = self.get_main_database(db.session).id
diff --git a/tests/dashboard_tests.py b/tests/dashboard_tests.py
new file mode 100644
index 0000000..3c8ed76
--- /dev/null
+++ b/tests/dashboard_tests.py
@@ -0,0 +1,300 @@
+# -*- coding: utf-8 -*-
+"""Unit tests for Superset"""
+from __future__ import absolute_import
+from __future__ import division
+from __future__ import print_function
+from __future__ import unicode_literals
+
+import json
+import unittest
+
+from flask import escape
+
+from superset import db, security_manager
+from superset.connectors.sqla.models import SqlaTable
+from superset.models import core as models
+from .base_tests import SupersetTestCase
+
+
+class DashboardTests(SupersetTestCase):
+
+    requires_examples = True
+
+    def __init__(self, *args, **kwargs):
+        super(DashboardTests, self).__init__(*args, **kwargs)
+
+    @classmethod
+    def setUpClass(cls):
+        pass
+
+    def setUp(self):
+        pass
+
+    def tearDown(self):
+        pass
+
+    def test_dashboard(self):
+        self.login(username='admin')
+        urls = {}
+        for dash in db.session.query(models.Dashboard).all():
+            urls[dash.dashboard_title] = dash.url
+        for title, url in urls.items():
+            assert escape(title) in self.client.get(url).data.decode('utf-8')
+
+    def test_dashboard_modes(self):
+        self.login(username='admin')
+        dash = (
+            db.session.query(models.Dashboard)
+            .filter_by(slug='births')
+            .first()
+        )
+        resp = self.get_resp(dash.url + '?edit=true&standalone=true')
+        self.assertIn('editMode&#34;: true', resp)
+        self.assertIn('standalone_mode&#34;: true', resp)
+
+    def test_save_dash(self, username='admin'):
+        self.login(username=username)
+        dash = db.session.query(models.Dashboard).filter_by(
+            slug='births').first()
+        positions = []
+        for i, slc in enumerate(dash.slices):
+            d = {
+                'col': 0,
+                'row': i * 4,
+                'size_x': 4,
+                'size_y': 4,
+                'slice_id': '{}'.format(slc.id)}
+            positions.append(d)
+        data = {
+            'css': '',
+            'expanded_slices': {},
+            'positions': positions,
+            'dashboard_title': dash.dashboard_title,
+        }
+        url = '/superset/save_dash/{}/'.format(dash.id)
+        resp = self.get_resp(url, data=dict(data=json.dumps(data)))
+        self.assertIn('SUCCESS', resp)
+
+    def test_save_dash_with_filter(self, username='admin'):
+        self.login(username=username)
+        dash = db.session.query(models.Dashboard).filter_by(
+            slug='world_health').first()
+        positions = []
+        for i, slc in enumerate(dash.slices):
+            d = {
+                'col': 0,
+                'row': i * 4,
+                'size_x': 4,
+                'size_y': 4,
+                'slice_id': '{}'.format(slc.id)}
+            positions.append(d)
+
+        filters = {str(dash.slices[0].id): {'region': ['North America']}}
+        default_filters = json.dumps(filters)
+        data = {
+            'css': '',
+            'expanded_slices': {},
+            'positions': positions,
+            'dashboard_title': dash.dashboard_title,
+            'default_filters': default_filters,
+        }
+
+        url = '/superset/save_dash/{}/'.format(dash.id)
+        resp = self.get_resp(url, data=dict(data=json.dumps(data)))
+        self.assertIn('SUCCESS', resp)
+
+        updatedDash = db.session.query(models.Dashboard).filter_by(
+            slug='world_health').first()
+        new_url = updatedDash.url
+        self.assertIn('region', new_url)
+
+        resp = self.get_resp(new_url)
+        self.assertIn('North America', resp)
+
+    def test_save_dash_with_dashboard_title(self, username='admin'):
+        self.login(username=username)
+        dash = (
+            db.session.query(models.Dashboard)
+            .filter_by(slug='births')
+            .first()
+        )
+        origin_title = dash.dashboard_title
+        positions = []
+        for i, slc in enumerate(dash.slices):
+            d = {
+                'col': 0,
+                'row': i * 4,
+                'size_x': 4,
+                'size_y': 4,
+                'slice_id': '{}'.format(slc.id)}
+            positions.append(d)
+        data = {
+            'css': '',
+            'expanded_slices': {},
+            'positions': positions,
+            'dashboard_title': 'new title',
+        }
+        url = '/superset/save_dash/{}/'.format(dash.id)
+        self.get_resp(url, data=dict(data=json.dumps(data)))
+        updatedDash = (
+            db.session.query(models.Dashboard)
+            .filter_by(slug='births')
+            .first()
+        )
+        self.assertEqual(updatedDash.dashboard_title, 'new title')
+        # # bring back dashboard original title
+        data['dashboard_title'] = origin_title
+        self.get_resp(url, data=dict(data=json.dumps(data)))
+
+    def test_copy_dash(self, username='admin'):
+        self.login(username=username)
+        dash = db.session.query(models.Dashboard).filter_by(
+            slug='births').first()
+        positions = []
+        for i, slc in enumerate(dash.slices):
+            d = {
+                'col': 0,
+                'row': i * 4,
+                'size_x': 4,
+                'size_y': 4,
+                'slice_id': '{}'.format(slc.id)}
+            positions.append(d)
+        data = {
+            'css': '',
+            'duplicate_slices': False,
+            'expanded_slices': {},
+            'positions': positions,
+            'dashboard_title': 'Copy Of Births',
+        }
+
+        # Save changes to Births dashboard and retrieve updated dash
+        dash_id = dash.id
+        url = '/superset/save_dash/{}/'.format(dash_id)
+        self.client.post(url, data=dict(data=json.dumps(data)))
+        dash = db.session.query(models.Dashboard).filter_by(
+            id=dash_id).first()
+        orig_json_data = dash.data
+
+        # Verify that copy matches original
+        url = '/superset/copy_dash/{}/'.format(dash_id)
+        resp = self.get_json_resp(url, data=dict(data=json.dumps(data)))
+        self.assertEqual(resp['dashboard_title'], 'Copy Of Births')
+        self.assertEqual(resp['position_json'], 
orig_json_data['position_json'])
+        self.assertEqual(resp['metadata'], orig_json_data['metadata'])
+        self.assertEqual(resp['slices'], orig_json_data['slices'])
+
+    def test_add_slices(self, username='admin'):
+        self.login(username=username)
+        dash = db.session.query(models.Dashboard).filter_by(
+            slug='births').first()
+        new_slice = db.session.query(models.Slice).filter_by(
+            slice_name='Mapbox Long/Lat').first()
+        existing_slice = db.session.query(models.Slice).filter_by(
+            slice_name='Name Cloud').first()
+        data = {
+            'slice_ids': [new_slice.data['slice_id'],
+                          existing_slice.data['slice_id']],
+        }
+        url = '/superset/add_slices/{}/'.format(dash.id)
+        resp = self.client.post(url, data=dict(data=json.dumps(data)))
+        assert 'SLICES ADDED' in resp.data.decode('utf-8')
+
+        dash = db.session.query(models.Dashboard).filter_by(
+            slug='births').first()
+        new_slice = db.session.query(models.Slice).filter_by(
+            slice_name='Mapbox Long/Lat').first()
+        assert new_slice in dash.slices
+        assert len(set(dash.slices)) == len(dash.slices)
+
+        # cleaning up
+        dash = db.session.query(models.Dashboard).filter_by(
+            slug='births').first()
+        dash.slices = [
+            o for o in dash.slices if o.slice_name != 'Mapbox Long/Lat']
+        db.session.commit()
+
+    def test_public_user_dashboard_access(self):
+        table = (
+            db.session
+            .query(SqlaTable)
+            .filter_by(table_name='birth_names')
+            .one()
+        )
+        # Try access before adding appropriate permissions.
+        self.revoke_public_access_to_table(table)
+        self.logout()
+
+        resp = self.get_resp('/slicemodelview/list/')
+        self.assertNotIn('birth_names</a>', resp)
+
+        resp = self.get_resp('/dashboardmodelview/list/')
+        self.assertNotIn('/superset/dashboard/births/', resp)
+
+        self.grant_public_access_to_table(table)
+
+        # Try access after adding appropriate permissions.
+        self.assertIn('birth_names', self.get_resp('/slicemodelview/list/'))
+
+        resp = self.get_resp('/dashboardmodelview/list/')
+        self.assertIn('/superset/dashboard/births/', resp)
+
+        self.assertIn('Births', self.get_resp('/superset/dashboard/births/'))
+
+        # Confirm that public doesn't have access to other datasets.
+        resp = self.get_resp('/slicemodelview/list/')
+        self.assertNotIn('wb_health_population</a>', resp)
+
+        resp = self.get_resp('/dashboardmodelview/list/')
+        self.assertNotIn('/superset/dashboard/world_health/', resp)
+
+    def test_dashboard_with_created_by_can_be_accessed_by_public_users(self):
+        self.logout()
+        table = (
+            db.session
+            .query(SqlaTable)
+            .filter_by(table_name='birth_names')
+            .one()
+        )
+        self.grant_public_access_to_table(table)
+
+        dash = db.session.query(models.Dashboard).filter_by(
+            slug='births').first()
+        dash.owners = [security_manager.find_user('admin')]
+        dash.created_by = security_manager.find_user('admin')
+        db.session.merge(dash)
+        db.session.commit()
+
+        assert 'Births' in self.get_resp('/superset/dashboard/births/')
+
+    def test_only_owners_can_save(self):
+        dash = (
+            db.session
+            .query(models.Dashboard)
+            .filter_by(slug='births')
+            .first()
+        )
+        dash.owners = []
+        db.session.merge(dash)
+        db.session.commit()
+        self.test_save_dash('admin')
+
+        self.logout()
+        self.assertRaises(
+            Exception, self.test_save_dash, 'alpha')
+
+        alpha = security_manager.find_user('alpha')
+
+        dash = (
+            db.session
+            .query(models.Dashboard)
+            .filter_by(slug='births')
+            .first()
+        )
+        dash.owners = [alpha]
+        db.session.merge(dash)
+        db.session.commit()
+        self.test_save_dash('alpha')
+
+
+if __name__ == '__main__':
+    unittest.main()
diff --git a/tests/druid_tests.py b/tests/druid_tests.py
index b0d9caf..d03378b 100644
--- a/tests/druid_tests.py
+++ b/tests/druid_tests.py
@@ -136,8 +136,8 @@ class DruidTests(SupersetTestCase):
         instance.query_dict = {}
         instance.query_builder.last_query.query_dict = {}
 
-        resp = self.get_resp('/superset/explore/druid/{}/'.format(
-            datasource_id))
+        resp = self.get_resp(
+            '/superset/explore/druid/{}/'.format(datasource_id))
         self.assertIn('test_datasource', resp)
         form_data = {
             'viz_type': 'table',

-- 
To stop receiving notification emails like this one, please contact
maximebeauche...@apache.org.

Reply via email to