This is an automated email from the ASF dual-hosted git repository.
johnbodley pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new 71db073 [external-metadata] Fix unknown column types (#6196)
71db073 is described below
commit 71db0736be1aed470fdf007698354a3f00a92078
Author: John Bodley <[email protected]>
AuthorDate: Thu Oct 25 18:56:24 2018 -0700
[external-metadata] Fix unknown column types (#6196)
---
superset/connectors/sqla/models.py | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/superset/connectors/sqla/models.py
b/superset/connectors/sqla/models.py
index 4b32586..0530e8f 100644
--- a/superset/connectors/sqla/models.py
+++ b/superset/connectors/sqla/models.py
@@ -11,6 +11,7 @@ from sqlalchemy import (
and_, asc, Boolean, Column, DateTime, desc, ForeignKey, Integer, or_,
select, String, Text,
)
+from sqlalchemy.exc import CompileError
from sqlalchemy.orm import backref, relationship
from sqlalchemy.schema import UniqueConstraint
from sqlalchemy.sql import column, literal_column, table, text
@@ -377,7 +378,10 @@ class SqlaTable(Model, BaseDatasource):
def external_metadata(self):
cols = self.database.get_columns(self.table_name, schema=self.schema)
for col in cols:
- col['type'] = '{}'.format(col['type'])
+ try:
+ col['type'] = str(col['type'])
+ except CompileError:
+ col['type'] = 'UNKNOWN'
return cols
@property
