This is an automated email from the ASF dual-hosted git repository.

ccwilliams pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 8bf9a5b  [dashboard] fix save/save-as flow (#6350)
8bf9a5b is described below

commit 8bf9a5b9a3898dc8dca21c97313c7126480ee360
Author: Chris Williams <[email protected]>
AuthorDate: Fri Nov 9 11:15:42 2018 -0800

    [dashboard] fix save/save-as flow (#6350)
    
    * [dashboard] fix save/save-as flow
    
    * [bugfix][dashboard] consistent response type for save/save-as
---
 superset/assets/src/dashboard/actions/dashboardState.js | 1 -
 superset/views/core.py                                  | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/superset/assets/src/dashboard/actions/dashboardState.js 
b/superset/assets/src/dashboard/actions/dashboardState.js
index 1afb4a5..cc0a7df 100644
--- a/superset/assets/src/dashboard/actions/dashboardState.js
+++ b/superset/assets/src/dashboard/actions/dashboardState.js
@@ -132,7 +132,6 @@ export function saveDashboardRequest(data, id, saveType) {
     SupersetClient.post({
       endpoint: `/superset/${path}/${id}/`,
       postPayload: { data },
-      parseMethod: null,
     })
       .then(response =>
         Promise.all([
diff --git a/superset/views/core.py b/superset/views/core.py
index 9b79b75..575e0de 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -1632,7 +1632,7 @@ class Superset(BaseSupersetView):
         session.merge(dash)
         session.commit()
         session.close()
-        return 'SUCCESS'
+        return json_success(json.dumps({'status': 'SUCCESS'}))
 
     @staticmethod
     def _set_dash_metadata(dashboard, data):

Reply via email to