This is an automated email from the ASF dual-hosted git repository.
maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new e0b3927 [bugfix] visualization flickers when rerunning query (#6374)
e0b3927 is described below
commit e0b3927ece1a3bdcd8d1cc818bd96509ce28d131
Author: Maxime Beauchemin <[email protected]>
AuthorDate: Mon Nov 12 10:49:27 2018 -0800
[bugfix] visualization flickers when rerunning query (#6374)
When hitting the Query button in the explore view, the previous chart
gets shown (flaskhed quickly) between the moment where the loading
spinner goes away and the new chart show up. This fix seems to prevent
this.
---
superset/assets/src/chart/Chart.jsx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/superset/assets/src/chart/Chart.jsx
b/superset/assets/src/chart/Chart.jsx
index f0fa145..67ae006 100644
--- a/superset/assets/src/chart/Chart.jsx
+++ b/superset/assets/src/chart/Chart.jsx
@@ -79,7 +79,7 @@ class Chart extends React.PureComponent {
handleRenderSuccess() {
const { actions, chartStatus, chartId, vizType } = this.props;
- if (chartStatus !== 'rendered') {
+ if (['loading', 'rendered'].indexOf(chartStatus) < 0) {
actions.chartRenderingSucceeded(chartId);
}
