This is an automated email from the ASF dual-hosted git repository.
maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new 96f5106 Fix Annotation (#6457)
96f5106 is described below
commit 96f510619c30f9907e63aeb6b0687765dc9b75b7
Author: aboganas <[email protected]>
AuthorDate: Sun Dec 9 19:00:47 2018 +0300
Fix Annotation (#6457)
---
superset/assets/src/visualizations/nvd3/NVD3Vis.js | 2 +-
superset/assets/src/visualizations/nvd3/PropTypes.js | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/superset/assets/src/visualizations/nvd3/NVD3Vis.js
b/superset/assets/src/visualizations/nvd3/NVD3Vis.js
index 5fbfed0..14ba9c4 100644
--- a/superset/assets/src/visualizations/nvd3/NVD3Vis.js
+++ b/superset/assets/src/visualizations/nvd3/NVD3Vis.js
@@ -146,7 +146,7 @@ const propTypes = {
// 'bar', 'dist-bar' or 'area'
showControls: PropTypes.bool,
// 'line' only
- showBrush: PropTypes.oneOf([true, false, 'auto']),
+ showBrush: PropTypes.oneOf([true, 'yes', false, 'no', 'auto']),
onBrushEnd: PropTypes.func,
// 'line-multi' or 'dual-line'
yAxis2Format: PropTypes.string,
diff --git a/superset/assets/src/visualizations/nvd3/PropTypes.js
b/superset/assets/src/visualizations/nvd3/PropTypes.js
index 6c3d58d..c537d31 100644
--- a/superset/assets/src/visualizations/nvd3/PropTypes.js
+++ b/superset/assets/src/visualizations/nvd3/PropTypes.js
@@ -58,6 +58,6 @@ export const annotationLayerType = PropTypes.shape({
showMarkers: PropTypes.bool,
sourceType: PropTypes.string,
style: PropTypes.string,
- value: PropTypes.string,
+ value: PropTypes.number,
width: PropTypes.number,
});
