This is an automated email from the ASF dual-hosted git repository.
maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new 817783f Allow any column to be filterable or groupable (#6764)
817783f is described below
commit 817783f4663331daa8499b6adcdf4b0ea24b28ff
Author: agrawaldevesh <[email protected]>
AuthorDate: Wed Jan 30 11:18:49 2019 -0800
Allow any column to be filterable or groupable (#6764)
This is not configurable and will be the default (and only !) behavior
going forward !
---
superset/connectors/sqla/models.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/superset/connectors/sqla/models.py
b/superset/connectors/sqla/models.py
index 73f45c4..fa53e31 100644
--- a/superset/connectors/sqla/models.py
+++ b/superset/connectors/sqla/models.py
@@ -861,13 +861,13 @@ class SqlaTable(Model, BaseDatasource):
dbcol = dbcols.get(col.name, None)
if not dbcol:
dbcol = TableColumn(column_name=col.name, type=datatype)
- dbcol.groupby = dbcol.is_string
- dbcol.filterable = dbcol.is_string
dbcol.sum = dbcol.is_num
dbcol.avg = dbcol.is_num
dbcol.is_dttm = dbcol.is_time
else:
dbcol.type = datatype
+ dbcol.groupby = True
+ dbcol.filterable = True
self.columns.append(dbcol)
if not any_date_col and dbcol.is_time:
any_date_col = col.name
