[incubator-superset] branch omnibar updated: added featureflag

[hugh]

This is an automated email from the ASF dual-hosted git repository.

hugh pushed a commit to branch omnibar
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/omnibar by this push:
     new c0c425d  added featureflag
c0c425d is described below

commit c0c425d1c64128ea4fff7b0fd3d90da43082ebf9
Author: hughhhh <hmi...@lyft.com>
AuthorDate: Thu Jan 31 16:04:04 2019 -0800

    added featureflag
---
 superset/assets/src/components/OmniContainer.jsx | 3 ++-
 superset/assets/src/featureFlags.ts              | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/superset/assets/src/components/OmniContainer.jsx 
b/superset/assets/src/components/OmniContainer.jsx
index 812f1d3..a86d41c 100644
--- a/superset/assets/src/components/OmniContainer.jsx
+++ b/superset/assets/src/components/OmniContainer.jsx
@@ -21,6 +21,7 @@ import { Modal } from 'react-bootstrap';
 import PropTypes from 'prop-types';
 import { t } from '@superset-ui/translation';
 import { SupersetClient } from '@superset-ui/connection';
+import { isFeatureEnabled, FeatureFlag } from 'src/featureFlags';
 import Omnibar from 'omnibar';
 import {
   Logger,
@@ -67,7 +68,7 @@ class OmniContainer extends React.Component {
 
   handleKeydown(event) {
     const controlOrCommand = event.ctrlKey || event.metaKey;
-    if (controlOrCommand) {
+    if (controlOrCommand && isFeatureEnabled(FeatureFlag.OMNIBAR)) {
       const isK = event.key === 'k' || event.keyCode === 83;
       if (isK) {
         this.setState({ showOmni: !this.state.showOmni });
diff --git a/superset/assets/src/featureFlags.ts 
b/superset/assets/src/featureFlags.ts
index a5415af..3686b35 100644
--- a/superset/assets/src/featureFlags.ts
+++ b/superset/assets/src/featureFlags.ts
@@ -2,6 +2,7 @@
 // check into source control. We're hardcoding the supported flags for now.
 export enum FeatureFlag {
   SCOPED_FILTER = 'SCOPED_FILTER',
+  OMNIBAR = 'OMNIBAR',
 }
 
 export type FeatureFlagMap = {