This is an automated email from the ASF dual-hosted git repository.

johnbodley pushed a commit to branch john-bodley--fix-migration-fb13d49b72f9
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git

commit 0c021bdd031303f9721972e54f48478aa50112ae
Author: John Bodley <[email protected]>
AuthorDate: Wed Mar 27 11:56:52 2019 -0700

    [migration] Fixing issue with fb13d49b72f9 downgrade
    
    This PR fixes an issue with the downgrade step of migration fb13d49b72f9 
which wrongfully labeled the field `metrics` rather than `metric`.
    
    to: @graceguo-supercat @michellethomas @mistercrunch
---
 superset/migrations/versions/fb13d49b72f9_better_filters.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset/migrations/versions/fb13d49b72f9_better_filters.py 
b/superset/migrations/versions/fb13d49b72f9_better_filters.py
index cac42c3..123a708 100644
--- a/superset/migrations/versions/fb13d49b72f9_better_filters.py
+++ b/superset/migrations/versions/fb13d49b72f9_better_filters.py
@@ -94,7 +94,7 @@ def downgrade():
             flts = params.get('filter_configs')
             if not flts:
                 continue
-            params['metrics'] = [flts[0].get('metric')]
+            params['metric'] = [flts[0].get('metric')]
             params['groupby'] = [o.get('column') for o in flts]
             slc.params = json.dumps(params, sort_keys=True)
         except Exception as e:

Reply via email to