This is an automated email from the ASF dual-hosted git repository.
michellet pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new 03752af fix PRODUCT-67916 Click OK button cannot close error message
modal (#7179)
03752af is described below
commit 03752af4e8560f66172cac3d7e246c895e10f1af
Author: Hannah Squier <[email protected]>
AuthorDate: Mon Apr 1 10:00:22 2019 -0700
fix PRODUCT-67916 Click OK button cannot close error message modal (#7179)
---
.../src/SqlLab/components/ExploreResultsButton.jsx | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/superset/assets/src/SqlLab/components/ExploreResultsButton.jsx
b/superset/assets/src/SqlLab/components/ExploreResultsButton.jsx
index 8411da7..2394c67 100644
--- a/superset/assets/src/SqlLab/components/ExploreResultsButton.jsx
+++ b/superset/assets/src/SqlLab/components/ExploreResultsButton.jsx
@@ -184,19 +184,21 @@ class ExploreResultsButton extends React.PureComponent {
render() {
const allowsSubquery = this.props.database &&
this.props.database.allows_subquery;
return (
- <Button
- bsSize="small"
- onClick={this.onClick}
- disabled={!allowsSubquery}
- tooltip={t('Explore the result set in the data exploration view')}
- >
+ <React.Fragment>
+ <Button
+ bsSize="small"
+ onClick={this.onClick}
+ disabled={!allowsSubquery}
+ tooltip={t('Explore the result set in the data exploration view')}
+ >
+ <InfoTooltipWithTrigger icon="line-chart" placement="top"
label="explore" /> {t('Explore')}
+ </Button>
<Dialog
ref={(el) => {
this.dialog = el;
}}
/>
- <InfoTooltipWithTrigger icon="line-chart" placement="top"
label="explore" /> {t('Explore')}
- </Button>
+ </React.Fragment>
);
}
}