This is an automated email from the ASF dual-hosted git repository.
maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new f6ebd78 Fixes dashboard export button missing download and #7353
(#7427)
f6ebd78 is described below
commit f6ebd789bfe762ca31038ee40cabf4dfb20ca885
Author: Russell Jurney <[email protected]>
AuthorDate: Wed May 1 21:04:28 2019 -0700
Fixes dashboard export button missing download and #7353 (#7427)
---
superset/templates/superset/export_dashboards.html | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/superset/templates/superset/export_dashboards.html
b/superset/templates/superset/export_dashboards.html
index 204ac2c..5ec6ff1 100644
--- a/superset/templates/superset/export_dashboards.html
+++ b/superset/templates/superset/export_dashboards.html
@@ -18,7 +18,16 @@
#}
<script>
window.onload = function() {
- window.open(window.location += '&action=go', '_blank');
- window.location = '{{ dashboards_url }}';
+
+ // See issue #7353, window.open fails
+ var a = document.createElement('a');
+ a.href = window.location + '&action=go';
+ a.download = 'dashboards.json';
+ document.body.appendChild(a);
+ a.click();
+ document.body.removeChild(a);
+
+ window.location = '{{ dashboards_url }}';
+
};
</script>
