This is an automated email from the ASF dual-hosted git repository.

beto pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new f68f979  Fix for polling queries (#7559)
f68f979 is described below

commit f68f9790528107d389950bb3317365fd2847cf56
Author: Beto Dealmeida <[email protected]>
AuthorDate: Thu May 23 09:17:00 2019 -0700

    Fix for polling queries (#7559)
    
    * Fix for polling queries
    
    * Revert changes due to 
https://github.com/apache/incubator-superset/pull/7575
---
 superset/assets/src/SqlLab/components/QueryAutoRefresh.jsx | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/superset/assets/src/SqlLab/components/QueryAutoRefresh.jsx 
b/superset/assets/src/SqlLab/components/QueryAutoRefresh.jsx
index 21d335b..6704d39 100644
--- a/superset/assets/src/SqlLab/components/QueryAutoRefresh.jsx
+++ b/superset/assets/src/SqlLab/components/QueryAutoRefresh.jsx
@@ -40,13 +40,8 @@ class QueryAutoRefresh extends React.PureComponent {
     // if there are started or running queries, this method should return true
     const { queries } = this.props;
     const now = new Date().getTime();
-
-    // due to a race condition, queries can be marked as successful before the
-    // results key is set; this is a workaround until we fix the underlying
-    // problem
     const isQueryRunning = q => (
-      ['running', 'started', 'pending', 'fetching'].indexOf(q.state) >= 0 ||
-      (q.state === 'success' && q.resultsKey === null)
+      ['running', 'started', 'pending', 'fetching'].indexOf(q.state) >= 0
     );
 
     return (

Reply via email to