This is an automated email from the ASF dual-hosted git repository.

graceguo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 2cd631a  Fix sync failed when datasource is schema-less (#8223)
2cd631a is described below

commit 2cd631a26c2f96149201923e17e53f4777200e3c
Author: Yongjie Zhao <[email protected]>
AuthorDate: Fri Sep 20 00:11:21 2019 +0800

    Fix sync failed when datasource is schema-less (#8223)
---
 superset/assets/src/datasource/DatasourceEditor.jsx | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/superset/assets/src/datasource/DatasourceEditor.jsx 
b/superset/assets/src/datasource/DatasourceEditor.jsx
index eb3c25b..014be93 100644
--- a/superset/assets/src/datasource/DatasourceEditor.jsx
+++ b/superset/assets/src/datasource/DatasourceEditor.jsx
@@ -261,10 +261,11 @@ export class DatasourceEditor extends React.PureComponent 
{
   }
   syncMetadata() {
     const { datasource } = this.state;
+    // Handle carefully when the schema is empty
     const endpoint = (
       `/datasource/external_metadata/${datasource.type}/${datasource.id}/` +
       `?db_id=${datasource.database.id}` +
-      `&schema=${datasource.schema}` +
+      `&schema=${datasource.schema || ''}` +
       `&table_name=${datasource.datasource_name}`
     );
     this.setState({ metadataLoading: true });

Reply via email to