This is an automated email from the ASF dual-hosted git repository.

villebro pushed a commit to branch 0.34
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git

commit a8576aad481a3b7b1ffdbd36ad64608782f1ad66
Author: Grace Guo <[email protected]>
AuthorDate: Tue Aug 20 11:48:15 2019 -0700

    [Explore view] Fix extra data fetch when user clicks Run Query (#8070)
---
 .../assets/src/explore/components/ExploreViewContainer.jsx  | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/superset/assets/src/explore/components/ExploreViewContainer.jsx 
b/superset/assets/src/explore/components/ExploreViewContainer.jsx
index 56b5e43..7990c9b 100644
--- a/superset/assets/src/explore/components/ExploreViewContainer.jsx
+++ b/superset/assets/src/explore/components/ExploreViewContainer.jsx
@@ -131,8 +131,6 @@ class ExploreViewContainer extends React.Component {
 
   /* eslint no-unused-vars: 0 */
   componentDidUpdate(prevProps, prevState) {
-    this.triggerQueryIfNeeded();
-
     const changedControlKeys = this.findChangedControlKeys(prevProps.controls, 
this.props.controls);
     if (this.hasDisplayControlChanged(changedControlKeys, 
this.props.controls)) {
       this.addHistory({});
@@ -213,17 +211,6 @@ class ExploreViewContainer extends React.Component {
     );
   }
 
-  triggerQueryIfNeeded() {
-    if (this.props.chart.triggerQuery && !this.hasErrors()) {
-      this.props.actions.postChartFormData(
-        this.props.form_data,
-        false,
-        this.props.timeout,
-        this.props.chart.id,
-      );
-    }
-  }
-
   addHistory({ isReplace = false, title }) {
     const { payload } = getExploreUrlAndPayload({ formData: 
this.props.form_data });
     const longUrl = getExploreLongUrl(this.props.form_data, null, false);

Reply via email to