This is an automated email from the ASF dual-hosted git repository.
graceguo pushed a change to branch scope-selector-modal
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git.
from 226bd40 fix code review comments (round 1)
add bd495e7 refactory after design review
No new revisions were added by this update.
Summary of changes:
.../{SqlLab/index.jsx => components/ChartIcon.jsx} | 14 +-
.../components/filterscope/FilterScopeModal.jsx | 6 +-
.../components/filterscope/FilterScopeSelector.jsx | 371 +++++++++++----------
.../components/filterscope/FilterScopeTree.jsx | 6 +-
.../filterscope/renderFilterFieldTreeNodes.jsx | 11 +-
.../filterscope/renderFilterScopeTreeNodes.jsx | 31 +-
.../stylesheets/filter-scope-selector.less | 42 +--
.../dashboard/util/buildFilterScopeTreeEntry.js | 65 ++++
superset/assets/src/dashboard/util/constants.js | 3 +
.../src/dashboard/util/getFilterFieldNodesTree.js | 21 +-
.../src/dashboard/util/getFilterScopeNodesTree.js | 132 ++++----
.../dashboard/util/getFilterScopeParentNodes.js | 6 +-
.../util/getKeyForFilterScopeTree.js} | 14 +-
.../src/dashboard/util/getRevertedFilterScope.js | 8 +-
.../util/getSelectedChartIdForFilterScopeTree.js | 53 +++
15 files changed, 476 insertions(+), 307 deletions(-)
copy superset/assets/src/{SqlLab/index.jsx => components/ChartIcon.jsx} (64%)
create mode 100644
superset/assets/src/dashboard/util/buildFilterScopeTreeEntry.js
copy superset/assets/src/{components/BootstrapSliderWrapper.css =>
dashboard/util/getKeyForFilterScopeTree.js} (74%)
create mode 100644
superset/assets/src/dashboard/util/getSelectedChartIdForFilterScopeTree.js
