This is an automated email from the ASF dual-hosted git repository. johnbodley pushed a commit to branch john-bodley--contributing-slice-params-2 in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
commit 66cfd40ef46d8061d1a03c6981fcaeaf08dfa82f Author: John Bodley <[email protected]> AuthorDate: Fri Nov 8 17:56:28 2019 -0800 Update CONTRIBUTING.md --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index c481061..2302e49 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -923,7 +923,7 @@ Note not all fields are correctly catagorized. The fields vary based on visualiz | `row_limit` | *number* | The **Row limit** widget | | `timeseries_limit_metric` | *object* | The **Sort By** widget | -Note the `metric` (or equivalent) and `timeseries_limit_metric` fields are all composed of the JSON representation of the `AdhocMetric` JavaScript type. +The `metric` (or equivalent) and `timeseries_limit_metric` fields are all composed of either metric names or the JSON representation of the `AdhocMetric` JavaScript type. The `adhoc_filters` is composed of the JSON represent of the `AdhocFilter` JavaScript type (which can comprise of columns or metrics depending on whether it is a WHERE or HAVING clause). The `all_columns_x`, `columns`, and `groupby` fields all represent column names. ### Options
