This is an automated email from the ASF dual-hosted git repository.

johnbodley pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 64de9aa  [docs] Updating slice parameter documentation. (#8535)
64de9aa is described below

commit 64de9aa056f1fa2864ff8ab58e90e6df2dada124
Author: John Bodley <[email protected]>
AuthorDate: Sun Nov 10 11:31:11 2019 -0800

    [docs] Updating slice parameter documentation. (#8535)
    
    * Update CONTRIBUTING.md
    
    * Update CONTRIBUTING.md
---
 CONTRIBUTING.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index c481061..cd617d7 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -923,7 +923,7 @@ Note not all fields are correctly catagorized. The fields 
vary based on visualiz
 | `row_limit`               | *number*                                         
 | The **Row limit** widget                          |
 | `timeseries_limit_metric` | *object*                                         
 | The **Sort By** widget                            |
 
-Note the `metric` (or equivalent) and `timeseries_limit_metric` fields are all 
composed of the JSON representation of the `AdhocMetric` JavaScript type.
+The `metric` (or equivalent) and `timeseries_limit_metric` fields are all 
composed of either metric names or the JSON representation of the `AdhocMetric` 
JavaScript type. The `adhoc_filters` is composed of the JSON represent of the 
`AdhocFilter` JavaScript type (which can comprise of columns or metrics 
depending on whether it is a WHERE or HAVING clause). The `all_columns`, 
`all_columns_x`, `columns`, `groupby`, and `order_by_cols` fields all represent 
column names. 
 
 ### Options
 

Reply via email to