This is an automated email from the ASF dual-hosted git repository.
maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new cc49aae re-enable pylint for database compatibility layer (#8772)
cc49aae is described below
commit cc49aae245ea9910b72b3a550c7363663399e176
Author: Will Barrett <[email protected]>
AuthorDate: Sat Dec 7 16:15:12 2019 -0800
re-enable pylint for database compatibility layer (#8772)
* Re-enable pylint for superset/db_engines/hive.py
* re-enable pylint for superset/db_engine_specs/elasticsearch.py
* Re-enable superset/db_engine_specs/__init__.py
* Re-enable pylint for superset/db_engine_specs/exasol.py
---
superset/db_engine_specs/__init__.py | 1 -
superset/db_engine_specs/elasticsearch.py | 3 +--
superset/db_engine_specs/exasol.py | 3 +--
superset/db_engines/hive.py | 7 ++++---
4 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/superset/db_engine_specs/__init__.py
b/superset/db_engine_specs/__init__.py
index 082c27c..51408ae 100644
--- a/superset/db_engine_specs/__init__.py
+++ b/superset/db_engine_specs/__init__.py
@@ -14,7 +14,6 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-# pylint: disable=C,R,W
"""Compatibility layer for different database engines
This modules stores logic specific to different database engines. Things
diff --git a/superset/db_engine_specs/elasticsearch.py
b/superset/db_engine_specs/elasticsearch.py
index 5ea06ba..5fdc3de 100644
--- a/superset/db_engine_specs/elasticsearch.py
+++ b/superset/db_engine_specs/elasticsearch.py
@@ -14,14 +14,13 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-# pylint: disable=C,R,W
from datetime import datetime
from typing import Dict, Optional
from superset.db_engine_specs.base import BaseEngineSpec
-class ElasticSearchEngineSpec(BaseEngineSpec):
+class ElasticSearchEngineSpec(BaseEngineSpec): # pylint:
disable=abstract-method
engine = "elasticsearch"
time_groupby_inline = True
time_secondary_columns = True
diff --git a/superset/db_engine_specs/exasol.py
b/superset/db_engine_specs/exasol.py
index 0e875d3..380b598 100644
--- a/superset/db_engine_specs/exasol.py
+++ b/superset/db_engine_specs/exasol.py
@@ -14,13 +14,12 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-# pylint: disable=C,R,W
from typing import List, Tuple
from superset.db_engine_specs.base import BaseEngineSpec
-class ExasolEngineSpec(BaseEngineSpec):
+class ExasolEngineSpec(BaseEngineSpec): # pylint: disable=abstract-method
"""Engine spec for Exasol"""
engine = "exa"
diff --git a/superset/db_engines/hive.py b/superset/db_engines/hive.py
index 62cae81..093b5eb 100644
--- a/superset/db_engines/hive.py
+++ b/superset/db_engines/hive.py
@@ -14,11 +14,12 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-# pylint: disable=C,R,W
-
+# pylint: disable=protected-access
# TODO: contribute back to pyhive.
-def fetch_logs(self, max_rows=1024, orientation=None):
+def fetch_logs(
+ self, max_rows=1024, orientation=None
+): # pylint: disable=unused-argument
"""Mocked. Retrieve the logs produced by the execution of the query.
Can be called multiple times to fetch the logs produced after
the previous call.
