This is an automated email from the ASF dual-hosted git repository.

erikrit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 78b1561  Make JSX Menu links open in new tab (#9191)
78b1561 is described below

commit 78b1561820df7b3c655ede67fba665964ea932c1
Author: Erik Ritter <[email protected]>
AuthorDate: Sun Feb 23 07:43:06 2020 -0800

    Make JSX Menu links open in new tab (#9191)
---
 superset-frontend/src/components/Menu/Menu.jsx | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/superset-frontend/src/components/Menu/Menu.jsx 
b/superset-frontend/src/components/Menu/Menu.jsx
index a9301da..e81420e 100644
--- a/superset-frontend/src/components/Menu/Menu.jsx
+++ b/superset-frontend/src/components/Menu/Menu.jsx
@@ -72,13 +72,21 @@ export default function Menu({
         <Nav className="navbar-right">
           {!navbarRight.user_is_anonymous && <NewMenu />}
           {navbarRight.documentation_url && (
-            <NavItem href={navbarRight.documentation_url} 
title="Documentation">
+            <NavItem
+              href={navbarRight.documentation_url}
+              target="_blank"
+              title="Documentation"
+            >
               <i className="fa fa-question" />
               &nbsp;
             </NavItem>
           )}
           {navbarRight.bug_report_url && (
-            <NavItem href={navbarRight.bug_report_url} title="Report a Bug">
+            <NavItem
+              href={navbarRight.bug_report_url}
+              target="_blank"
+              title="Report a Bug"
+            >
               <i className="fa fa-bug" />
               &nbsp;
             </NavItem>

Reply via email to