This is an automated email from the ASF dual-hosted git repository.
erikrit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new 1992069 Upgrade typescript to 3.8.2 (#9189)
1992069 is described below
commit 1992069af10a84c0311be57f9be221711ca84be0
Author: Jianchao Yang <[email protected]>
AuthorDate: Tue Feb 25 08:44:26 2020 -0800
Upgrade typescript to 3.8.2 (#9189)
---
.gitignore | 3 ---
CONTRIBUTING.md | 4 ++--
superset-frontend/.eslintignore | 1 +
superset-frontend/.gitignore | 4 ++++
superset-frontend/package-lock.json | 6 +++---
superset-frontend/package.json | 2 +-
superset-frontend/spec/javascripts/utils/safeStringify_spec.ts | 2 +-
superset-frontend/webpack.config.js | 2 +-
8 files changed, 13 insertions(+), 11 deletions(-)
diff --git a/.gitignore b/.gitignore
index b1d505a..d069eef 100644
--- a/.gitignore
+++ b/.gitignore
@@ -58,9 +58,6 @@ rat-results.txt
*.js.map
node_modules
npm-debug.log*
-superset-frontend/coverage/*
-superset-frontend/cypress/screenshots
-superset-frontend/cypress/videos
superset/static/assets
superset/static/version_info.json
yarn-error.log
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 1d8571a..cef83d1 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -528,7 +528,7 @@ best practices.
Superset supports a server-wide feature flag system, which eases the
incremental development of features. To add a new feature flag, simply modify
`superset_config.py` with something like the following:
-```
+```python
FEATURE_FLAGS = {
'SCOPED_FILTER': True,
}
@@ -536,7 +536,7 @@ FEATURE_FLAGS = {
If you want to use the same flag in the client code, also add it to the
FeatureFlag TypeScript enum in `superset-frontend/src/featureFlags.ts`. For
example,
-```
+```typescript
export enum FeatureFlag {
SCOPED_FILTER = 'SCOPED_FILTER',
}
diff --git a/superset-frontend/.eslintignore b/superset-frontend/.eslintignore
index 25b08e0..e21e918 100644
--- a/superset-frontend/.eslintignore
+++ b/superset-frontend/.eslintignore
@@ -25,5 +25,6 @@ stylesheets/*
vendor/*
docs/*
src/dashboard/deprecated/*
+src/temp/*
**/node_modules
*.d.ts
diff --git a/superset-frontend/.gitignore b/superset-frontend/.gitignore
new file mode 100644
index 0000000..0598bbb
--- /dev/null
+++ b/superset-frontend/.gitignore
@@ -0,0 +1,4 @@
+coverage/*
+cypress/screenshots
+cypress/videos
+src/temp
diff --git a/superset-frontend/package-lock.json
b/superset-frontend/package-lock.json
index 5421f93..291151c 100644
--- a/superset-frontend/package-lock.json
+++ b/superset-frontend/package-lock.json
@@ -24728,9 +24728,9 @@
"integrity": "sha1-hnrHTjhkGHsdPUfZlqeOxciDB3c="
},
"typescript": {
- "version": "3.5.3",
- "resolved":
"https://registry.npmjs.org/typescript/-/typescript-3.5.3.tgz";,
- "integrity":
"sha512-ACzBtm/PhXBDId6a6sDJfroT2pOWt/oOnk4/dElG5G33ZL776N3Y6/6bKZJBFpd+b05F3Ct9qDjMeJmRWtE2/g==",
+ "version": "3.8.2",
+ "resolved":
"https://registry.npmjs.org/typescript/-/typescript-3.8.2.tgz";,
+ "integrity":
"sha512-EgOVgL/4xfVrCMbhYKUQTdF37SQn4Iw73H5BgCrF1Abdun7Kwy/QZsE/ssAy0y4LxBbvua3PIbFsbRczWWnDdQ==",
"dev": true
},
"typpy": {
diff --git a/superset-frontend/package.json b/superset-frontend/package.json
index f518449..01c8cd3 100644
--- a/superset-frontend/package.json
+++ b/superset-frontend/package.json
@@ -220,7 +220,7 @@
"ts-jest": "^24.0.2",
"ts-loader": "^5.4.5",
"tslib": "^1.10.0",
- "typescript": "^3.5.3",
+ "typescript": "^3.8.2",
"url-loader": "^1.0.1",
"webpack": "^4.19.0",
"webpack-assets-manifest": "^3.0.1",
diff --git a/superset-frontend/spec/javascripts/utils/safeStringify_spec.ts
b/superset-frontend/spec/javascripts/utils/safeStringify_spec.ts
index acf7748..21ea647 100644
--- a/superset-frontend/spec/javascripts/utils/safeStringify_spec.ts
+++ b/superset-frontend/spec/javascripts/utils/safeStringify_spec.ts
@@ -19,7 +19,7 @@
import { safeStringify } from '../../../src/utils/safeStringify';
class Noise {
- public next: Noise;
+ public next?: Noise;
}
describe('Stringify utility testing', () => {
diff --git a/superset-frontend/webpack.config.js
b/superset-frontend/webpack.config.js
index b45a958..c7a957a 100644
--- a/superset-frontend/webpack.config.js
+++ b/superset-frontend/webpack.config.js
@@ -281,7 +281,7 @@ const config = {
hot: true,
index: '', // This line is needed to enable root proxying
inline: true,
- stats: { colors: true },
+ stats: 'minimal',
overlay: true,
port: devserverPort,
// Only serves bundled files from webpack-dev-server
