[incubator-superset] branch master updated: [Build] moves prettier check to separate script (#9591)

[craigrueda]

This is an automated email from the ASF dual-hosted git repository.

craigrueda pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new cb51d78  [Build] moves prettier check to separate script (#9591)
cb51d78 is described below

commit cb51d7833f7cd41dc98a4b1fdc7eada59b267d8f
Author: ʈᵃᵢ <tdupree...@gmail.com>
AuthorDate: Mon Apr 20 15:06:33 2020 -0700

    [Build] moves prettier check to separate script (#9591)
    
    * [Build] moves prettier check to separate script
    
    * rename step: eslint -> lint
---
 .github/workflows/superset-frontend.yml | 3 ++-
 superset-frontend/package.json          | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/superset-frontend.yml 
b/.github/workflows/superset-frontend.yml
index e14d75e..f8ab832 100644
--- a/.github/workflows/superset-frontend.yml
+++ b/.github/workflows/superset-frontend.yml
@@ -13,10 +13,11 @@ jobs:
       uses: apache-superset/cached-dependencies@adc6f73
       with:
         run: npm-install
-    - name: eslint
+    - name: lint
       working-directory: ./superset-frontend
       run: |
         npm run lint
+        npm run prettier-check
     - name: unit tests
       working-directory: ./superset-frontend
       run: |
diff --git a/superset-frontend/package.json b/superset-frontend/package.json
index 351e014..5e31a17 100644
--- a/superset-frontend/package.json
+++ b/superset-frontend/package.json
@@ -17,7 +17,8 @@
     "build-dev": "cross-env NODE_OPTIONS=--max_old_space_size=8192 
NODE_ENV=development webpack --mode=development --colors --progress",
     "build-instrumented": "cross-env NODE_ENV=development 
BABEL_ENV=instrumented webpack --mode=development --colors --progress",
     "build": "cross-env NODE_OPTIONS=--max_old_space_size=8192 
NODE_ENV=production webpack --mode=production --colors --progress",
-    "lint": "prettier --check '{src,stylesheets}/**/*.{css,less,sass,scss}' && 
eslint --ignore-path=.eslintignore --ext .js,.jsx,.ts,.tsx .",
+    "lint": "eslint --ignore-path=.eslintignore --ext .js,.jsx,.ts,.tsx .",
+    "prettier-check": "prettier --check 
'{src,stylesheets}/**/*.{css,less,sass,scss}'",
     "lint-fix": "eslint --fix --ignore-path=.eslintignore --ext 
.js,.jsx,.ts,tsx . && npm run clean-css",
     "clean-css": "prettier --write 
'{src,stylesheets}/**/*.{css,less,sass,scss}'"
   },