This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 858082f  Fix email reports (#9695)
858082f is described below

commit 858082f9750aa430c9f60c06dfce6a7d6703c707
Author: Bogdan <[email protected]>
AuthorDate: Fri May 1 07:42:58 2020 -0700

    Fix email reports (#9695)
    
    * Fix email reports
    
    * Address comments and inherit from str
    
    Co-authored-by: bogdan kyryliuk <[email protected]>
---
 superset/models/schedules.py | 6 +++---
 superset/views/schedules.py  | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/superset/models/schedules.py b/superset/models/schedules.py
index 6e2157f..f70b076 100644
--- a/superset/models/schedules.py
+++ b/superset/models/schedules.py
@@ -29,17 +29,17 @@ from superset.models.helpers import AuditMixinNullable, 
ImportMixin
 metadata = Model.metadata  # pylint: disable=no-member
 
 
-class ScheduleType(enum.Enum):
+class ScheduleType(str, enum.Enum):
     slice = "slice"
     dashboard = "dashboard"
 
 
-class EmailDeliveryType(enum.Enum):
+class EmailDeliveryType(str, enum.Enum):
     attachment = "Attachment"
     inline = "Inline"
 
 
-class SliceEmailReportFormat(enum.Enum):
+class SliceEmailReportFormat(str, enum.Enum):
     visualization = "Visualization"
     data = "Raw data"
 
diff --git a/superset/views/schedules.py b/superset/views/schedules.py
index e84e341..6f35a7a 100644
--- a/superset/views/schedules.py
+++ b/superset/views/schedules.py
@@ -156,7 +156,7 @@ class EmailScheduleView(
 class DashboardEmailScheduleView(
     EmailScheduleView
 ):  # pylint: disable=too-many-ancestors
-    schedule_type = ScheduleType.dashboard.value
+    schedule_type = ScheduleType.dashboard
     schedule_type_model = Dashboard
 
     add_title = _("Schedule Email Reports for Dashboards")
@@ -215,7 +215,7 @@ class DashboardEmailScheduleView(
 
 
 class SliceEmailScheduleView(EmailScheduleView):  # pylint: 
disable=too-many-ancestors
-    schedule_type = ScheduleType.slice.value
+    schedule_type = ScheduleType.slice
     schedule_type_model = Slice
     add_title = _("Schedule Email Reports for Charts")
     edit_title = add_title

Reply via email to