This is an automated email from the ASF dual-hosted git repository.
johnbodley pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new 36627af fix: Resolves a regression from #9939 (#10033)
36627af is described below
commit 36627af916c1001f0f156a9bd4fc6d7480006c55
Author: John Bodley <4567245+john-bod...@users.noreply.github.com>
AuthorDate: Wed Jun 10 13:42:08 2020 -0700
fix: Resolves a regression from #9939 (#10033)
Co-authored-by: John Bodley <john.bod...@airbnb.com>
---
superset/views/core.py | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/superset/views/core.py b/superset/views/core.py
index 44cade9..6df7d34 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -917,9 +917,6 @@ class Superset(BaseSupersetView):
)
if action in ("saveas", "overwrite"):
- if not slc:
- return json_error_response("The slice does not exist")
-
return self.save_or_overwrite_slice(
slc,
slice_add_perm,
@@ -1003,7 +1000,7 @@ class Superset(BaseSupersetView):
def save_or_overwrite_slice(
self,
- slc: Slice,
+ slc: Optional[Slice],
slice_add_perm: bool,
slice_overwrite_perm: bool,
slice_download_perm: bool,
@@ -1025,6 +1022,7 @@ class Superset(BaseSupersetView):
form_data.get("adhoc_filters", [])
)
+ assert slc
slc.params = json.dumps(form_data, indent=2, sort_keys=True)
slc.datasource_name = datasource_name
slc.viz_type = form_data["viz_type"]
